From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F86C433FE for ; Sun, 8 May 2022 19:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231342AbiEHTV0 (ORCPT ); Sun, 8 May 2022 15:21:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379311AbiEHSnn (ORCPT ); Sun, 8 May 2022 14:43:43 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A217DF40; Sun, 8 May 2022 11:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652035192; x=1683571192; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ku5z9ZOYUJh+GqggbRmp5uymILKAy+CEwjEQNBeO+Ps=; b=HgUZGve7GtbEh9ovsuv8D2FBpnYI0KWYJS+eft1rgTZv65YAkJ5Jk2HM ULit1MrKc6ulQWJ/YBciOH9JyiAtZ3neeAov0OCTbFG5k+huZ6wAr1Xl9 wHOxjkFqlGXigUVfD/an52cJQUoOnSrHn9XuVRcBBpEwZQwW5YZHmb7aW gq2WebXyZhzAqm3htHQDeGhpAROAzURznFMwcUFvVUA0TFkFY4KxIS+TS hK6LiMFHYAGPTe5jDHN4OndL758217XcZ7uBfgUL/RkPPs5bUVQPmfRM1 4rFEyDbll6+k6Wjr9yCFMN8nbXxwvm3tH14NJm3SgddXiMLsseydnz8We g==; X-IronPort-AV: E=McAfee;i="6400,9594,10341"; a="329450432" X-IronPort-AV: E=Sophos;i="5.91,208,1647327600"; d="scan'208";a="329450432" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2022 11:39:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,208,1647327600"; d="scan'208";a="601650575" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 08 May 2022 11:39:48 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nnloq-000Fic-7M; Sun, 08 May 2022 18:39:48 +0000 Date: Mon, 9 May 2022 02:39:20 +0800 From: kernel test robot To: =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= , jikos@kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, benjamin.tissoires@redhat.com, spbnick@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stefanberzl@gmail.com, albertofanjul@gmail.com, =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= Subject: Re: [PATCH for-5.19/uclogic 1/7] HID: uclogic: Move param printing to a function Message-ID: <202205090241.d7Xmt8GT-lkp@intel.com> References: <20220508160146.13004-2-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220508160146.13004-2-jose.exposito89@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi "José, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [cannot apply to v5.18-rc5 next-20220506] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Jos-Exp-sito/DIGImend-patches-part-VI/20220509-000510 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next config: x86_64-randconfig-a003-20220509 (https://download.01.org/0day-ci/archive/20220509/202205090241.d7Xmt8GT-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a385645b470e2d3a1534aae618ea56b31177639f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4c0671e4ce0687136ff71aa65539cd3a2798d99d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jos-Exp-sito/DIGImend-patches-part-VI/20220509-000510 git checkout 4c0671e4ce0687136ff71aa65539cd3a2798d99d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/hid/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/hid/hid-uclogic-params.c:48: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Dump tablet interface pen parameters with hid_dbg(), indented with one tab. drivers/hid/hid-uclogic-params.c:80: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Dump tablet interface frame parameters with hid_dbg(), indented with two drivers/hid/hid-uclogic-params.c:105: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Dump tablet interface parameters with hid_dbg(). vim +48 drivers/hid/hid-uclogic-params.c 46 47 /** > 48 * Dump tablet interface pen parameters with hid_dbg(), indented with one tab. 49 * 50 * @hdev: The HID device the pen parameters describe. 51 * @pen: The pen parameters to dump. 52 */ 53 static void uclogic_params_pen_hid_dbg(const struct hid_device *hdev, 54 const struct uclogic_params_pen *pen) 55 { 56 size_t i; 57 58 hid_dbg(hdev, "\t.usage_invalid = %s\n", 59 (pen->usage_invalid ? "true" : "false")); 60 hid_dbg(hdev, "\t.desc_ptr = %p\n", pen->desc_ptr); 61 hid_dbg(hdev, "\t.desc_size = %u\n", pen->desc_size); 62 hid_dbg(hdev, "\t.id = %u\n", pen->id); 63 hid_dbg(hdev, "\t.subreport_list = {\n"); 64 for (i = 0; i < ARRAY_SIZE(pen->subreport_list); i++) { 65 hid_dbg(hdev, "\t\t{0x%02hhx, %hhu}%s\n", 66 pen->subreport_list[i].value, 67 pen->subreport_list[i].id, 68 i < (ARRAY_SIZE(pen->subreport_list) - 1) ? "," : ""); 69 } 70 hid_dbg(hdev, "\t}\n"); 71 hid_dbg(hdev, "\t.inrange = %s\n", 72 uclogic_params_pen_inrange_to_str(pen->inrange)); 73 hid_dbg(hdev, "\t.fragmented_hires = %s\n", 74 (pen->fragmented_hires ? "true" : "false")); 75 hid_dbg(hdev, "\t.tilt_y_flipped = %s\n", 76 (pen->tilt_y_flipped ? "true" : "false")); 77 } 78 -- 0-DAY CI Kernel Test Service https://01.org/lkp