From: Christoph Hellwig <hch@lst.de>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Christoph Hellwig <hch@lst.de>,
linux-usb@vger.kernel.org, bugzilla-daemon@kernel.org,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Satadru Pramanik <satadru@umich.edu>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>
Subject: Re: [Bug 215890] New: Regression in 5.18: bcm5974 trackpad causes error: xhci_hcd rejecting DMA map of vmalloc memory
Date: Fri, 13 May 2022 12:47:49 +0200 [thread overview]
Message-ID: <20220513104749.GA2634@lst.de> (raw)
In-Reply-To: <20220513103724.GA2289@lst.de>
On Fri, May 13, 2022 at 12:37:24PM +0200, Christoph Hellwig wrote:
> > #regzbot introduced: f5ff79fddf0efecca538046b5cc20fb3ded2
>
> Well, this just uncovered an existing bug in the driver. You can not
> just dma map memory returned from dma_alloc_coherent, and this driver
> would already get vmalloc memory on arm/arm64 platforms anyway, we
> now just do the same on x86 as well.
From a quick look through the trace it seems somehow
usb_hcd_map_urb_for_dma tries to create another DMA mapping for a buffer
allocated from usb_alloc_coherent that uses a dma coherent allocation
below. It really needs to use the dma address returned from
usb_alloc_coherent instead of trying to map the URB again. But I don't
have the slightest idea of why that only happens for this particular
setup, and I really need some helpe from the usb folks to untangle it
prev parent reply other threads:[~2022-05-13 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-215890-208809@https.bugzilla.kernel.org/>
2022-05-04 8:42 ` [Bug 215890] New: Regression in 5.18: bcm5974 trackpad causes error: xhci_hcd rejecting DMA map of vmalloc memory Thorsten Leemhuis
2022-05-13 8:24 ` Thorsten Leemhuis
2022-05-13 10:37 ` Christoph Hellwig
2022-05-13 10:47 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513104749.GA2634@lst.de \
--to=hch@lst.de \
--cc=bugzilla-daemon@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=rydberg@bitmath.org \
--cc=satadru@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).