From: Jeff LaBundy <jeff@labundy.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH] dt-bindings: input: use generic node names
Date: Fri, 27 May 2022 17:44:21 -0500 [thread overview]
Message-ID: <20220527224401.GA395557@nixie71> (raw)
In-Reply-To: <20220524093136.7980-1-krzysztof.kozlowski@linaro.org>
Hi Krzysztof,
On Tue, May 24, 2022 at 11:31:36AM +0200, Krzysztof Kozlowski wrote:
> Devicetree specification expects nodes to have generic names, if
> possible, so replace custom ones with something generic. For gpio-keys,
> the more popular format is "key-xxx" instead of "xxx-key", so choose the
> first one.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../devicetree/bindings/input/fsl,mpr121-touchkey.yaml | 4 ++--
> Documentation/devicetree/bindings/input/gpio-keys.yaml | 4 ++--
> Documentation/devicetree/bindings/input/iqs269a.yaml | 2 +-
> Documentation/devicetree/bindings/input/iqs626a.yaml | 2 +-
For iqs*a.yaml:
Acked-by: Jeff LaBundy <jeff@labundy.com>
Does there happen to be a list of preferred names based on device
function, or is it simply a matter of what seems to be most common?
> .../devicetree/bindings/input/microchip,cap11xx.yaml | 2 +-
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml b/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml
> index 878464f128dc..5139af287d3e 100644
> --- a/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml
> +++ b/Documentation/devicetree/bindings/input/fsl,mpr121-touchkey.yaml
> @@ -57,7 +57,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - mpr121@5a {
> + touchkey@5a {
> compatible = "fsl,mpr121-touchkey";
> reg = <0x5a>;
> interrupt-parent = <&gpio1>;
> @@ -77,7 +77,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - mpr121@5a {
> + touchkey@5a {
> compatible = "fsl,mpr121-touchkey";
> reg = <0x5a>;
> poll-interval = <20>;
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
> index 7fe1966ea28a..93f601c58984 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
> @@ -127,13 +127,13 @@ examples:
> compatible = "gpio-keys";
> autorepeat;
>
> - up {
> + key-up {
> label = "GPIO Key UP";
> linux,code = <103>;
> gpios = <&gpio1 0 1>;
> };
>
> - down {
> + key-down {
> label = "GPIO Key DOWN";
> linux,code = <108>;
> interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> diff --git a/Documentation/devicetree/bindings/input/iqs269a.yaml b/Documentation/devicetree/bindings/input/iqs269a.yaml
> index 9c154e5e1a91..d84d69f5455d 100644
> --- a/Documentation/devicetree/bindings/input/iqs269a.yaml
> +++ b/Documentation/devicetree/bindings/input/iqs269a.yaml
> @@ -475,7 +475,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - iqs269a@44 {
> + touch@44 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/Documentation/devicetree/bindings/input/iqs626a.yaml b/Documentation/devicetree/bindings/input/iqs626a.yaml
> index 0cb736c541c9..dd727befe564 100644
> --- a/Documentation/devicetree/bindings/input/iqs626a.yaml
> +++ b/Documentation/devicetree/bindings/input/iqs626a.yaml
> @@ -751,7 +751,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - iqs626a@44 {
> + touch@44 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> diff --git a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> index d5d6bced3148..96358b12f9b2 100644
> --- a/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> +++ b/Documentation/devicetree/bindings/input/microchip,cap11xx.yaml
> @@ -112,7 +112,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - cap1188@28 {
> + touch@28 {
> compatible = "microchip,cap1188";
> interrupt-parent = <&gpio1>;
> interrupts = <0 0>;
> --
> 2.34.1
>
Kind regards,
Jeff LaBundy
next prev parent reply other threads:[~2022-05-27 22:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 9:31 [PATCH] dt-bindings: input: use generic node names Krzysztof Kozlowski
2022-05-24 11:11 ` Andreas Kemnade
2022-05-24 11:28 ` Krzysztof Kozlowski
2022-05-26 2:20 ` Rob Herring
2022-05-27 22:44 ` Jeff LaBundy [this message]
2022-05-29 14:21 ` Krzysztof Kozlowski
2022-05-28 20:41 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527224401.GA395557@nixie71 \
--to=jeff@labundy.com \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).