linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "José Expósito" <jose.exposito89@gmail.com>
To: Nikolai Kondrashov <spbnick@gmail.com>
Cc: Stefan Berzl <stefanberzl@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: Add support for the xp-pen deco mini7 tablet
Date: Sat, 25 Jun 2022 17:24:38 +0200	[thread overview]
Message-ID: <20220625152438.GA4820@elementary> (raw)
In-Reply-To: <6ebb8b6c-901e-f7b1-f29e-2182fd183b8d@gmail.com>

Hi Nickolai,

Nikolai Kondrashov wrote:
> I think it's OK to just ignore the first packet for these devices, even if the
> ACK packet is not sent for some of them. Even with the report rate of 20 years
> ago nobody would've noticed if you dropped one packet.

A bit more of context about this initial packet:

These XP-PEN devices need to receive a packet of data to be fully functional.
The driver sends it:

	02 b0 04 00 00 00 00 00 00 00

And in response to the activation packet, the tablet sends an ACK:

	02 b1 04 00 00 00 00 00 00 00

In my case the packet is ignored but on Stepfan's tablet, this packet sends to
mouse pointer to the 0,0 coordinates.

Looking at the data he added to his last email, his tablet ACK has 2 extra
bytes, making it match the size of a pen report.
Because the ACK packet starts with 02 it looks like it is  interpreted as a pen
report with all values set to 0, including X and Y.

We are not worried about a packet being dropped, we would like to filter the
ACK so it does not get handled as a pen report. This should allow to
avoid sending the pointer to 0,0 on device connection.

It is not a super anoying bug, but it'll be nice if we could avoid it.

Best wishes,
Jose

  reply	other threads:[~2022-06-25 15:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <85312611-797f-2dd2-f864-f7c13cb889f9@gmail.com>
     [not found] ` <nycvar.YFH.7.76.2206091058530.14340@cbobk.fhfr.pm>
2022-06-22 21:31   ` [PATCH] hid: Add support for the xp-pen deco mini7 tablet Stefan Berzl
2022-06-23 17:51     ` José Expósito
2022-06-23 18:01       ` Nikolai Kondrashov
2022-06-23 22:46         ` Stefan Berzl
2022-06-24  6:08           ` Nikolai Kondrashov
2022-06-24  6:08           ` Nikolai Kondrashov
2022-06-25 15:24             ` José Expósito [this message]
2022-06-23 22:24       ` Stefan Berzl
2022-06-25 15:30         ` José Expósito
2022-03-18 18:37 Stefan Berzl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220625152438.GA4820@elementary \
    --to=jose.exposito89@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spbnick@gmail.com \
    --cc=stefanberzl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).