From: Chris Morgan <macroalpha82@gmail.com>
To: linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
contact@artur-rojek.eu, jic23@kernel.org, paul@crapouillou.net,
linux-iio@vger.kernel.org, Chris Morgan <macromorgan@hotmail.com>,
Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: [PATCH v8 2/3] Input: adc-joystick - Add polled input device support
Date: Thu, 21 Jul 2022 11:46:02 -0500 [thread overview]
Message-ID: <20220721164603.13534-3-macroalpha82@gmail.com> (raw)
In-Reply-To: <20220721164603.13534-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
Add polled input device support to the adc-joystick driver. This is
useful for devices which do not have hardware capable triggers on
their SARADC. Code modified from adc-joystick.c changes made by Maya
Matuszczyk.
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/input/joystick/adc-joystick.c | 82 ++++++++++++++++++++-------
1 file changed, 62 insertions(+), 20 deletions(-)
diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c
index 78ebca7d400a..085b8e10dfb5 100644
--- a/drivers/input/joystick/adc-joystick.c
+++ b/drivers/input/joystick/adc-joystick.c
@@ -26,8 +26,23 @@ struct adc_joystick {
struct adc_joystick_axis *axes;
struct iio_channel *chans;
int num_chans;
+ bool polled;
};
+static void adc_joystick_poll(struct input_dev *input)
+{
+ struct adc_joystick *joy = input_get_drvdata(input);
+ int i, val, ret;
+
+ for (i = 0; i < joy->num_chans; i++) {
+ ret = iio_read_channel_raw(&joy->chans[i], &val);
+ if (ret < 0)
+ return;
+ input_report_abs(input, joy->axes[i].code, val);
+ }
+ input_sync(input);
+}
+
static int adc_joystick_handle(const void *data, void *private)
{
struct adc_joystick *joy = private;
@@ -178,7 +193,9 @@ static int adc_joystick_probe(struct platform_device *pdev)
struct input_dev *input;
int error;
int bits;
+ int chan_storage;
int i;
+ unsigned int poll_interval;
joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
if (!joy)
@@ -192,16 +209,31 @@ static int adc_joystick_probe(struct platform_device *pdev)
return error;
}
- /* Count how many channels we got. NULL terminated. */
+ if (device_property_present(dev, "poll-interval")) {
+ error = device_property_read_u32(dev, "poll-interval",
+ &poll_interval);
+ if (error)
+ return error;
+ joy->polled = true;
+ }
+
+ /* Count how many channels we got. NULL terminated. Do not check the
+ * storage size if using polling.
+ */
+ chan_storage = joy->chans[0].channel->scan_type.storagebits;
for (i = 0; joy->chans[i].indio_dev; i++) {
- bits = joy->chans[i].channel->scan_type.storagebits;
- if (!bits || bits > 16) {
- dev_err(dev, "Unsupported channel storage size\n");
- return -EINVAL;
- }
- if (bits != joy->chans[0].channel->scan_type.storagebits) {
- dev_err(dev, "Channels must have equal storage size\n");
- return -EINVAL;
+ if (!joy->polled) {
+ bits = joy->chans[i].channel->scan_type.storagebits;
+ if (!bits || bits > 16) {
+ dev_err(dev,
+ "Unsupported channel storage size\n");
+ return -EINVAL;
+ }
+ if (bits != chan_storage) {
+ dev_err(dev,
+ "Channels must be equal size\n");
+ return -EINVAL;
+ }
}
}
joy->num_chans = i;
@@ -215,8 +247,14 @@ static int adc_joystick_probe(struct platform_device *pdev)
joy->input = input;
input->name = pdev->name;
input->id.bustype = BUS_HOST;
- input->open = adc_joystick_open;
- input->close = adc_joystick_close;
+
+ if (joy->polled) {
+ input_setup_polling(input, adc_joystick_poll);
+ input_set_poll_interval(input, poll_interval);
+ } else {
+ input->open = adc_joystick_open;
+ input->close = adc_joystick_close;
+ }
error = adc_joystick_set_axes(dev, joy);
if (error)
@@ -229,16 +267,20 @@ static int adc_joystick_probe(struct platform_device *pdev)
return error;
}
- joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
- if (IS_ERR(joy->buffer)) {
- dev_err(dev, "Unable to allocate callback buffer\n");
- return PTR_ERR(joy->buffer);
- }
+ if (!joy->polled) {
+ joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
+ joy);
+ if (IS_ERR(joy->buffer)) {
+ dev_err(dev, "Unable to allocate callback buffer\n");
+ return PTR_ERR(joy->buffer);
+ }
- error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
- if (error) {
- dev_err(dev, "Unable to add action\n");
- return error;
+ error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
+ joy->buffer);
+ if (error) {
+ dev_err(dev, "Unable to add action\n");
+ return error;
+ }
}
return 0;
--
2.25.1
next prev parent reply other threads:[~2022-07-21 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 16:46 [PATCH v8 0/3] dt-bindings: adc-joystick: add poll-interval Chris Morgan
2022-07-21 16:46 ` [PATCH v8 1/3] " Chris Morgan
2022-07-21 16:46 ` Chris Morgan [this message]
2022-07-28 20:26 ` [PATCH v8 2/3] Input: adc-joystick - Add polled input device support Artur Rojek
2022-07-29 16:30 ` Chris Morgan
[not found] ` <20220729163048.GA123@wintermute.localdomain>
2022-08-03 16:53 ` Chris Morgan
2022-07-21 16:46 ` [PATCH v8 3/3] arm64: dts: rockchip: Update joystick to polled for OG2 Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721164603.13534-3-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=contact@artur-rojek.eu \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=maccraft123mc@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).