From: Nate Yocom <nate@yocom.org>
To: dmitry.torokhov@gmail.com
Cc: nate@yocom.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, hadess@hadess.net,
benjamin.tissoires@redhat.com
Subject: [PATCH v5 4/4] Input: joystick: xpad: Add X-Box Adaptive Controller XBox button
Date: Thu, 25 Aug 2022 15:24:20 -0700 [thread overview]
Message-ID: <20220825222420.6833-5-nate@yocom.org> (raw)
In-Reply-To: <20220825222420.6833-1-nate@yocom.org>
Adaptive controller sets 0x02 bit for this button, all others set 0x01
so presence of either is used for BTN_MODE.
Signed-off-by: Nate Yocom <nate@yocom.org>
Tested-by: Bastien Nocera <hadess@hadess.net>
---
drivers/input/joystick/xpad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 9557e4768f14..ece38f00dfff 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -859,7 +859,7 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
if (data[1] == 0x30)
xpadone_ack_mode_report(xpad, data[2]);
- input_report_key(dev, BTN_MODE, data[4] & 0x01);
+ input_report_key(dev, BTN_MODE, data[4] & 0x03);
input_sync(dev);
return;
}
--
2.30.2
prev parent reply other threads:[~2022-08-25 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 22:24 [PATCH v5 0/4] Input: joystick: xpad: Add X-Box Adaptive Controller support Nate Yocom
2022-08-25 22:24 ` [PATCH v5 1/4] " Nate Yocom
2022-08-25 22:24 ` [PATCH v5 2/4] Input: joystick: xpad: Add ABS_PROFILE axis value to uapi Nate Yocom
2022-08-27 10:40 ` Bastien Nocera
2022-08-29 19:07 ` Nate Yocom
2022-09-07 15:41 ` Bastien Nocera
2022-09-08 5:36 ` Dmitry Torokhov
2022-09-08 6:51 ` Benjamin Tissoires
2022-09-09 1:25 ` Peter Hutterer
2022-09-08 17:36 ` Nate Yocom
2022-08-25 22:24 ` [PATCH v5 3/4] Input: joystick: xpad: Add X-Box Adaptive Controller Profile button Nate Yocom
2022-08-25 22:24 ` Nate Yocom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825222420.6833-5-nate@yocom.org \
--to=nate@yocom.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).