From: "Nuno Sá" <nuno.sa@analog.com>
To: linux-kernel@vger.kernel.org,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-input@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Hennerich <michael.hennerich@analog.com>
Subject: [PATCH v4 06/10] input: keyboard: adp5588-keys: do not check for irq presence
Date: Mon, 29 Aug 2022 15:15:49 +0200 [thread overview]
Message-ID: <20220829131553.690063-7-nuno.sa@analog.com> (raw)
In-Reply-To: <20220829131553.690063-1-nuno.sa@analog.com>
There's no need for an extra check for 'client-irq'. Just let it fail when
calling 'request_irq()'.
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/input/keyboard/adp5588-keys.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index 2b00bc0f174c..e716efbb2105 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -727,11 +727,6 @@ static int adp5588_probe(struct i2c_client *client,
return -EIO;
}
- if (!client->irq) {
- dev_err(&client->dev, "no IRQ?\n");
- return -EINVAL;
- }
-
kpad = devm_kzalloc(&client->dev, sizeof(*kpad), GFP_KERNEL);
if (!kpad)
return -ENOMEM;
--
2.37.2
next prev parent reply other threads:[~2022-08-29 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 13:15 [PATCH v4 00/10] adp5588-keys refactor and fw properties support Nuno Sá
2022-08-29 13:15 ` [PATCH v4 01/10] input: keyboard: adp5588-keys: support gpi key events as 'gpio keys' Nuno Sá
2022-08-29 14:18 ` Andy Shevchenko
2022-08-31 12:37 ` Linus Walleij
2022-08-29 13:15 ` [PATCH v4 02/10] gpio: gpio-adp5588: drop the driver Nuno Sá
2022-08-31 12:21 ` Linus Walleij
2022-08-31 12:22 ` Linus Walleij
2022-08-31 12:24 ` Sa, Nuno
2022-08-29 13:15 ` [PATCH v4 03/10] input: keyboard: adp5588-keys: bail out on returned error Nuno Sá
2022-08-29 13:15 ` [PATCH v4 04/10] input: keyboard: adp5588-keys: add support for fw properties Nuno Sá
2022-08-29 13:15 ` [PATCH v4 05/10] dt-bindings: input: adp5588: add bindings Nuno Sá
2022-08-29 13:15 ` Nuno Sá [this message]
2022-08-29 13:15 ` [PATCH v4 07/10] input: keyboard: adp5588-keys: fix coding style warnings Nuno Sá
2022-08-29 13:15 ` [PATCH v4 08/10] input: keyboard: adp5588-keys: add optional reset gpio Nuno Sá
2022-08-29 13:15 ` [PATCH v4 09/10] input: keyboard: adp5588-keys: add regulator support Nuno Sá
2022-08-29 13:15 ` [PATCH v4 10/10] input: keyboard: adp5588-keys: Use new PM macros Nuno Sá
2022-08-31 4:19 ` [PATCH v4 00/10] adp5588-keys refactor and fw properties support Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829131553.690063-7-nuno.sa@analog.com \
--to=nuno.sa@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).