* [PATCH v2 2/2] input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-07 5:52 [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
@ 2022-09-07 5:52 ` Yunlong Jia
2022-09-07 9:18 ` [PATCH v2 1/2] dt-bindings: " David Heidelberg
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Yunlong Jia @ 2022-09-07 5:52 UTC (permalink / raw)
To: LKML
Cc: Douglas Anderson, Bob Moragues, Yunlong Jia, Henry Sun,
Yunlong Jia, Dmitry Torokhov, Guenter Roeck, Johnny Chuang,
linux-input
The eth3915n requires more delay time than the eth3500 when reset.
Define EKTH3915_RESET_DELAY_MSEC as the reset delay time of eth3915n,
about 300ms.
Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v1)
drivers/input/touchscreen/elants_i2c.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index c9dd703b0c7d8..60ddb58281bdf 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -116,6 +116,7 @@
#define ELAN_POWERON_DELAY_USEC 500
#define ELAN_RESET_DELAY_MSEC 20
+#define EKTH3915_RESET_DELAY_MSEC 300
/* FW boot code version */
#define BC_VER_H_BYTE_FOR_EKTH3900x1_I2C 0x72
@@ -133,6 +134,7 @@
enum elants_chip_id {
EKTH3500,
EKTF3624,
+ EKTH3915,
};
enum elants_state {
@@ -664,6 +666,7 @@ static int elants_i2c_initialize(struct elants_data *ts)
switch (ts->chip_id) {
case EKTH3500:
+ case EKTH3915:
if (!error)
error = elants_i2c_query_ts_info_ekth(ts);
break;
@@ -1361,7 +1364,17 @@ static int elants_i2c_power_on(struct elants_data *ts)
if (error)
return error;
- msleep(ELAN_RESET_DELAY_MSEC);
+ if (ts->chip_id == EKTH3915)
+ /*
+ * There need delay 300ms for power on sequence.
+ * T1 + T2 + T3 >= 305 ms
+ * T1: 0<time<500us
+ * T2: >5ms
+ * T3: >300ms
+ */
+ msleep(EKTH3915_RESET_DELAY_MSEC);
+ else
+ msleep(ELAN_RESET_DELAY_MSEC);
return 0;
}
@@ -1686,6 +1699,7 @@ static const struct i2c_device_id elants_i2c_id[] = {
{ DEVICE_NAME, EKTH3500 },
{ "ekth3500", EKTH3500 },
{ "ektf3624", EKTF3624 },
+ { "ekth3915", EKTH3915 },
{ }
};
MODULE_DEVICE_TABLE(i2c, elants_i2c_id);
@@ -1702,6 +1716,7 @@ MODULE_DEVICE_TABLE(acpi, elants_acpi_id);
static const struct of_device_id elants_of_match[] = {
{ .compatible = "elan,ekth3500", .data = (void *)EKTH3500 },
{ .compatible = "elan,ektf3624", .data = (void *)EKTF3624 },
+ { .compatible = "elan,ekth3915", .data = (void *)EKTH3915 },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, elants_of_match);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-07 5:52 [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
2022-09-07 5:52 ` [PATCH v2 2/2] " Yunlong Jia
@ 2022-09-07 9:18 ` David Heidelberg
2022-09-07 14:49 ` Doug Anderson
2022-09-09 1:44 ` Rob Herring
3 siblings, 0 replies; 5+ messages in thread
From: David Heidelberg @ 2022-09-07 9:18 UTC (permalink / raw)
To: Yunlong Jia, LKML
Cc: Douglas Anderson, Bob Moragues, Yunlong Jia, Henry Sun,
Dmitry Torokhov, Rob Herring, devicetree, linux-input
Acked-by: David Heidelberg <david@ixit.cz>
On 07/09/2022 07:52, Yunlong Jia wrote:
> Add an elan touch screen chip eth3915n.
> This chip requires more delay time than the eth3500.
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v1)
>
> .../devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> index a9b53c2e6f0ab..d28625372f5ac 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> @@ -17,6 +17,7 @@ properties:
> enum:
> - elan,ektf3624
> - elan,ekth3500
> + - elan,ekth3915
>
> reg:
> maxItems: 1
--
David Heidelberg
Consultant Software Engineer
Matrix: @okias:matrix.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-07 5:52 [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
2022-09-07 5:52 ` [PATCH v2 2/2] " Yunlong Jia
2022-09-07 9:18 ` [PATCH v2 1/2] dt-bindings: " David Heidelberg
@ 2022-09-07 14:49 ` Doug Anderson
2022-09-09 1:44 ` Rob Herring
3 siblings, 0 replies; 5+ messages in thread
From: Doug Anderson @ 2022-09-07 14:49 UTC (permalink / raw)
To: Yunlong Jia
Cc: LKML, Bob Moragues, Yunlong Jia, Henry Sun, David Heidelberg,
Dmitry Torokhov, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:HID CORE LAYER
Hi,
On Tue, Sep 6, 2022 at 10:52 PM Yunlong Jia
<yunlong.jia@ecs.corp-partner.google.com> wrote:
>
> Add an elan touch screen chip eth3915n.
> This chip requires more delay time than the eth3500.
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v1)
Technically that's not true. You changed your Signed-off-by between v1
and v2. That would be something to mention in the changelog.
Also: I suspect that when a maintainer lands your patch that they'll
get into trouble. That's because your email was sent from
"yunlong.jia@ecs.corp-partner.google.com" but your "Signed-off-by" was
"yunlong.jia@ecs.com.tw". If I try grabbing your patch from the
mailing lists, applying it, and then running it through "checkpatch":
./scripts/checkpatch.pl
0001-input-touchscreen-elants_i2c-Add-eth3915n-touchscree.patch
WARNING: From:/Signed-off-by: email address mismatch: 'From: Yunlong
Jia <yunlong.jia@ecs.corp-partner.google.com>' != 'Signed-off-by:
Yunlong Jia <yunlong.jia@ecs.com.tw>'
If I had to guess, the problem is with Google's SMTP servers. If you
logged into the SMTP server with your "corp-partner" address then
Google's SMTP server will automatically re-write your "From" address
to be whatever address you logged in with. I'd guess your options are:
1. Use an official SMTP server for "ecs.com.tw"
...or...
2. I _suspect_ that it will work to set the git config
"sendemail.envelopeSender" to
"yunlong.jia@ecs.corp-partner.google.com". I haven't tested this but I
think it'll work.
Note that when you send a v3, make sure to carry David Heidelberg's Ack.
-Doug
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-07 5:52 [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
` (2 preceding siblings ...)
2022-09-07 14:49 ` Doug Anderson
@ 2022-09-09 1:44 ` Rob Herring
3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-09-09 1:44 UTC (permalink / raw)
To: Yunlong Jia
Cc: LKML, Douglas Anderson, Bob Moragues, Yunlong Jia, Henry Sun,
David Heidelberg, Dmitry Torokhov, devicetree, linux-input
On Wed, Sep 07, 2022 at 05:52:03AM +0000, Yunlong Jia wrote:
> Add an elan touch screen chip eth3915n.
> This chip requires more delay time than the eth3500.
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
Author and Sob emails need to match.
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v1)
>
> .../devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> index a9b53c2e6f0ab..d28625372f5ac 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> @@ -17,6 +17,7 @@ properties:
> enum:
> - elan,ektf3624
> - elan,ekth3500
> + - elan,ekth3915
>
> reg:
> maxItems: 1
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread