From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] Input: auo-pixcir-ts - do not force rising edge interrupt trigger
Date: Wed, 14 Sep 2022 07:14:26 -0700 [thread overview]
Message-ID: <20220914141428.2201784-3-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20220914141428.2201784-1-dmitry.torokhov@gmail.com>
Instead of hard-coding rising edge as the interrupt trigger, let's rely on
the platform (ACPI, DT) to configure the interrupt properly.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/auo-pixcir-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
index c3bce9fb2c94..4960a50f59ea 100644
--- a/drivers/input/touchscreen/auo-pixcir-ts.c
+++ b/drivers/input/touchscreen/auo-pixcir-ts.c
@@ -612,7 +612,7 @@ static int auo_pixcir_probe(struct i2c_client *client,
error = devm_request_threaded_irq(&client->dev, client->irq,
NULL, auo_pixcir_interrupt,
- IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ IRQF_ONESHOT,
input_dev->name, ts);
if (error) {
dev_err(&client->dev, "irq %d requested failed, %d\n",
--
2.37.2.789.g6183377224-goog
next prev parent reply other threads:[~2022-09-14 14:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 14:14 [PATCH 1/5] Input: auo-pixcir-ts - drop support for platform data Dmitry Torokhov
2022-09-14 14:14 ` [PATCH 2/5] Input: auo-pixcir-ts - switch to using gpiod API Dmitry Torokhov
2022-09-14 15:04 ` Heiko Stuebner
2022-09-14 15:15 ` Dmitry Torokhov
2022-09-15 13:08 ` Heiko Stuebner
2022-09-18 14:40 ` Linus Walleij
2022-09-14 14:14 ` Dmitry Torokhov [this message]
2022-09-14 15:05 ` [PATCH 3/5] Input: auo-pixcir-ts - do not force rising edge interrupt trigger Heiko Stuebner
2022-09-14 14:14 ` [PATCH 4/5] Input: auo-pixcir-ts - switch to using generic device properties Dmitry Torokhov
2022-09-14 15:06 ` Heiko Stuebner
2022-09-14 14:14 ` [PATCH 5/5] dt-bindings: input: auo-pixcir-ts: fix gpio and interrupt properties Dmitry Torokhov
2022-09-14 15:07 ` Heiko Stuebner
2022-09-14 14:40 ` [PATCH 1/5] Input: auo-pixcir-ts - drop support for platform data Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220914141428.2201784-3-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).