linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: hid-elan: use default remove for hid device
@ 2022-09-15 12:34 Marcus Folkesson
       [not found] ` <CAM8FrK+qj8aao5mEzzvmBS0Zi=qXqVXnE6X4uQP4Hp6-cPedJw@mail.gmail.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2022-09-15 12:34 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires, Marcus Folkesson
  Cc: linux-kernel, linux-input

hid_device_remove() will call hid_hw_stop() as default .remove function
if no function is specified.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/hid/hid-elan.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c
index 8e4a5528e25d..76d93fc48f6a 100644
--- a/drivers/hid/hid-elan.c
+++ b/drivers/hid/hid-elan.c
@@ -507,11 +507,6 @@ static int elan_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	return ret;
 }
 
-static void elan_remove(struct hid_device *hdev)
-{
-	hid_hw_stop(hdev);
-}
-
 static const struct hid_device_id elan_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_HP_X2),
 	  .driver_data = ELAN_HAS_LED },
@@ -529,7 +524,6 @@ static struct hid_driver elan_driver = {
 	.input_configured = elan_input_configured,
 	.raw_event = elan_raw_event,
 	.probe = elan_probe,
-	.remove = elan_remove,
 };
 
 module_hid_driver(elan_driver);
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: hid-elan: use default remove for hid device
       [not found] ` <CAM8FrK+qj8aao5mEzzvmBS0Zi=qXqVXnE6X4uQP4Hp6-cPedJw@mail.gmail.com>
@ 2022-10-14  9:37   ` Benjamin Tissoires
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2022-10-14  9:37 UTC (permalink / raw)
  To: Marcus Folkesson; +Cc: Jiri Kosina, linux-kernel, linux-input

On Fri, Oct 14, 2022 at 10:25 AM Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
>
>
> Den tors 15 sep. 2022 kl 14:28 skrev Marcus Folkesson <marcus.folkesson@gmail.com>:
>>
>> hid_device_remove() will call hid_hw_stop() as default .remove function
>> if no function is specified.
>>
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>> ---
>
>
> Ping on this patch and the other similar patches.

Hi Marcus,

Just a quick FYI, we are still in the merge window period, and as such
we can not push anything in linux-next that is not 6.1 material. Given
that I intend to take those in 6.2, I will be able to process those
patches next week at the earliest.

Cheers,
Benjamin


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-14  9:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15 12:34 [PATCH] HID: hid-elan: use default remove for hid device Marcus Folkesson
     [not found] ` <CAM8FrK+qj8aao5mEzzvmBS0Zi=qXqVXnE6X4uQP4Hp6-cPedJw@mail.gmail.com>
2022-10-14  9:37   ` Benjamin Tissoires

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).