From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-input@vger.kernel.org>
Cc: <dmitry.torokhov@gmail.com>
Subject: [PATCH -next 2/4] Input: bcm-keypad - Switch to use dev_err_probe() helper
Date: Tue, 20 Sep 2022 23:30:53 +0800 [thread overview]
Message-ID: <20220920153055.3465115-2-yangyingliang@huawei.com> (raw)
In-Reply-To: <20220920153055.3465115-1-yangyingliang@huawei.com>
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/input/keyboard/bcm-keypad.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
index 56a919ec23b5..bc8bd78d74f5 100644
--- a/drivers/input/keyboard/bcm-keypad.c
+++ b/drivers/input/keyboard/bcm-keypad.c
@@ -368,11 +368,9 @@ static int bcm_kp_probe(struct platform_device *pdev)
kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
if (IS_ERR(kp->clk)) {
error = PTR_ERR(kp->clk);
- if (error != -ENOENT) {
- if (error != -EPROBE_DEFER)
- dev_err(&pdev->dev, "Failed to get clock\n");
- return error;
- }
+ if (error != -ENOENT)
+ return dev_err_probe(&pdev->dev, error,
+ "Failed to get clock\n");
dev_dbg(&pdev->dev,
"No clock specified. Assuming it's enabled\n");
kp->clk = NULL;
--
2.25.1
next prev parent reply other threads:[~2022-09-20 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 15:30 [PATCH -next 1/4] Input: adc-joystick - Switch to use dev_err_probe() helper Yang Yingliang
2022-09-20 15:30 ` Yang Yingliang [this message]
2022-09-22 8:47 ` [PATCH -next 2/4] Input: bcm-keypad " Mattijs Korpershoek
2022-09-20 15:30 ` [PATCH -next 3/4] Input: gpio_keys " Yang Yingliang
2022-09-22 8:48 ` Mattijs Korpershoek
2022-09-22 8:52 ` Mattijs Korpershoek
2022-09-20 15:30 ` [PATCH -next 4/4] Input: gpio_keys_polled " Yang Yingliang
2022-09-22 8:48 ` Mattijs Korpershoek
2022-09-22 8:52 ` Mattijs Korpershoek
2022-09-22 8:46 ` [PATCH -next 1/4] Input: adc-joystick " Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920153055.3465115-2-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox