From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: gupt21@gmail.com, benjamin.tissoires@redhat.com,
jikos@kernel.org, linux-iio@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v6 3/3] HID: mcp2221: add ADC/DAC support via iio subsystem
Date: Sun, 2 Oct 2022 14:50:52 +0100 [thread overview]
Message-ID: <20221002145052.036003b5@jic23-huawei> (raw)
In-Reply-To: <20221001005208.8010-4-matt.ranostay@konsulko.com>
On Fri, 30 Sep 2022 17:52:08 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:
> Add support for 3x 10-bit ADC and 1x DAC channels registered via the iio
> subsystem.
>
> To prevent breakage and unexpected dependencies this support only is
> only built if CONFIG_IIO is enabled, and is only weakly referenced by
> 'imply IIO' within the respective Kconfig.
>
> Additionally the iio device only gets registered if at least one channel
> is enabled in the power-on configuration read from SRAM.
>
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
I'm never particularly keen on drivers from elsewhere in the tree gaining
IIO support - but that's just because it can make a bit of a mess of
changes to the IIO subsystem itself. Having said that, this code looks fine to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2022-10-02 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 0:52 [PATCH v6 0/3] HID: mcp2221: iio support and device resource management Matt Ranostay
2022-10-01 0:52 ` [PATCH v6 1/3] HID: mcp2221: switch i2c registration to devm functions Matt Ranostay
2022-10-01 0:52 ` [PATCH v6 2/3] HID: mcp2221: change 'select GPIOLIB' to imply Matt Ranostay
2022-10-21 11:50 ` Benjamin Tissoires
2022-10-21 12:12 ` Jiri Kosina
2022-10-21 12:29 ` Benjamin Tissoires
2022-10-01 0:52 ` [PATCH v6 3/3] HID: mcp2221: add ADC/DAC support via iio subsystem Matt Ranostay
2022-10-02 13:50 ` Jonathan Cameron [this message]
2022-10-18 13:00 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221002145052.036003b5@jic23-huawei \
--to=jic23@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=gupt21@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).