* [PATCH] Input: tps6507x-ts: remove variable loops
@ 2022-10-20 18:16 Colin Ian King
2022-10-21 13:04 ` Mattijs Korpershoek
2022-10-24 11:59 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-10-20 18:16 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: kernel-janitors, linux-kernel
The variable loops is being incremented but is never referenced,
it is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/input/touchscreen/tps6507x-ts.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index 357a3108f2e5..f48871767763 100644
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -119,7 +119,6 @@ static s32 tps6507x_adc_conversion(struct tps6507x_ts *tsc,
static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
{
s32 ret;
- s32 loops = 0;
u8 val;
ret = tps6507x_write_u8(tsc, TPS6507X_REG_ADCONFIG,
@@ -141,7 +140,6 @@ static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
ret = tps6507x_read_u8(tsc, TPS6507X_REG_INT, &val);
if (ret)
return ret;
- loops++;
}
return ret;
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: tps6507x-ts: remove variable loops
2022-10-20 18:16 [PATCH] Input: tps6507x-ts: remove variable loops Colin Ian King
@ 2022-10-21 13:04 ` Mattijs Korpershoek
2022-10-24 11:59 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2022-10-21 13:04 UTC (permalink / raw)
To: Colin Ian King, Dmitry Torokhov, linux-input
Cc: kernel-janitors, linux-kernel
On Thu, Oct 20, 2022 at 19:16, Colin Ian King <colin.i.king@gmail.com> wrote:
> The variable loops is being incremented but is never referenced,
> it is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/input/touchscreen/tps6507x-ts.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
> index 357a3108f2e5..f48871767763 100644
> --- a/drivers/input/touchscreen/tps6507x-ts.c
> +++ b/drivers/input/touchscreen/tps6507x-ts.c
> @@ -119,7 +119,6 @@ static s32 tps6507x_adc_conversion(struct tps6507x_ts *tsc,
> static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
> {
> s32 ret;
> - s32 loops = 0;
> u8 val;
>
> ret = tps6507x_write_u8(tsc, TPS6507X_REG_ADCONFIG,
> @@ -141,7 +140,6 @@ static s32 tps6507x_adc_standby(struct tps6507x_ts *tsc)
> ret = tps6507x_read_u8(tsc, TPS6507X_REG_INT, &val);
> if (ret)
> return ret;
> - loops++;
> }
>
> return ret;
> --
> 2.37.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: tps6507x-ts: remove variable loops
2022-10-20 18:16 [PATCH] Input: tps6507x-ts: remove variable loops Colin Ian King
2022-10-21 13:04 ` Mattijs Korpershoek
@ 2022-10-24 11:59 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2022-10-24 11:59 UTC (permalink / raw)
To: Colin Ian King; +Cc: linux-input, kernel-janitors, linux-kernel
On Thu, Oct 20, 2022 at 07:16:42PM +0100, Colin Ian King wrote:
> The variable loops is being incremented but is never referenced,
> it is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-24 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 18:16 [PATCH] Input: tps6507x-ts: remove variable loops Colin Ian King
2022-10-21 13:04 ` Mattijs Korpershoek
2022-10-24 11:59 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).