From: Shawn Guo <shawnguo@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-input@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: imx6qdl-sabre*: fix Egalax touchscreen properties
Date: Sun, 23 Oct 2022 17:30:16 +0800 [thread overview]
Message-ID: <20221023093016.GC125525@dragon> (raw)
In-Reply-To: <20220920042608.1865560-1-dmitry.torokhov@gmail.com>
On Mon, Sep 19, 2022 at 09:26:05PM -0700, Dmitry Torokhov wrote:
> This patch fixes interrupt trigger (should be level low as that is what the
> driver is always using), the GPIO that is the interrupt source that is also
> used to wake up chip by driving the line low.
>
> The proper polarity is be needed for converting the driver to gpiod API.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Looks good to me. Let me know if you want me to pick it up. Otherwise,
Acked-by: Shawn Guo <shawnguo@kernel.org>
Shawn
> ---
> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 4 ++--
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> index 1368a4762037..1883350d004e 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> @@ -451,8 +451,8 @@ touchscreen@4 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_egalax_int>;
> interrupt-parent = <&gpio2>;
> - interrupts = <28 IRQ_TYPE_EDGE_FALLING>;
> - wakeup-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
> + interrupts = <28 IRQ_TYPE_LEVEL_LOW>;
> + wakeup-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 37482a9023fc..09f4c2fa3ad6 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -311,8 +311,8 @@ touchscreen@4 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_i2c2_egalax_int>;
> interrupt-parent = <&gpio6>;
> - interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> - wakeup-gpios = <&gpio6 8 GPIO_ACTIVE_HIGH>;
> + interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
> + wakeup-gpios = <&gpio6 8 GPIO_ACTIVE_LOW>;
> };
>
> ov5640: camera@3c {
> @@ -450,8 +450,8 @@ egalax_ts@4 {
> compatible = "eeti,egalax_ts";
> reg = <0x04>;
> interrupt-parent = <&gpio6>;
> - interrupts = <7 2>;
> - wakeup-gpios = <&gpio6 7 0>;
> + interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> + wakeup-gpios = <&gpio6 7 GPIO_ACTIVE_LOW>;
> };
>
> magnetometer@e {
> --
> 2.37.3.968.ga6b4b080e4-goog
>
next prev parent reply other threads:[~2022-10-23 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 4:26 [PATCH 1/4] ARM: dts: imx6qdl-sabre*: fix Egalax touchscreen properties Dmitry Torokhov
2022-09-20 4:26 ` [PATCH 2/4] dt-binding: input: egalax-ts: fix GPIO and IRQ in example Dmitry Torokhov
2022-09-21 6:47 ` Krzysztof Kozlowski
2022-09-20 4:26 ` [PATCH 3/4] Input: egalax_ts - switch to using gpiod API Dmitry Torokhov
2022-09-20 4:26 ` [PATCH 4/4] Input: egalax_ts - do not hardcode interrupt trigger Dmitry Torokhov
2022-10-23 9:30 ` Shawn Guo [this message]
2022-10-24 12:04 ` [PATCH 1/4] ARM: dts: imx6qdl-sabre*: fix Egalax touchscreen properties Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221023093016.GC125525@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).