From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0924DECAAA1 for ; Sun, 23 Oct 2022 09:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbiJWJa2 (ORCPT ); Sun, 23 Oct 2022 05:30:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbiJWJa1 (ORCPT ); Sun, 23 Oct 2022 05:30:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5944060E9D; Sun, 23 Oct 2022 02:30:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69A5A60AF7; Sun, 23 Oct 2022 09:30:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3444FC433D6; Sun, 23 Oct 2022 09:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666517422; bh=SvZU34knkzTksbDV9/R1UQaBdQ4Vp+P93Kb6ii8rmFI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IdS3KcbBazezxh9b26kfs977M6yjyqN0x7jvtpV3Q5ywMUbCdObrVuPS0OEKBg6Up AUbvS3j2LuHGFqAvJMcaHQaOpw26+XGcU328Q4qn9Jg9EfQohWWl7Cl21AcBj8sF3z vbyTl8JsU+nEBOS49rJMLoQk67n/0NUUGT+CLpZU4ZNYqgu79QgzbPhIAs6TmWqWkS V5SyNz6DTXrvgtVqrAPVxeWnU5q9pGsokJSGRSMfu5s1IDTTac76H+C9kV65xs90bL HxOkVbw/nqYM9QSy9hTkL1a8XdqxMc5qCyUl9cnw6d+6xKW6EjF8iaG5qpi60GXnfH AHwXX9o8pr9Vg== Date: Sun, 23 Oct 2022 17:30:16 +0800 From: Shawn Guo To: Dmitry Torokhov Cc: Sascha Hauer , linux-input@vger.kernel.org, Krzysztof Kozlowski , Fabio Estevam , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] ARM: dts: imx6qdl-sabre*: fix Egalax touchscreen properties Message-ID: <20221023093016.GC125525@dragon> References: <20220920042608.1865560-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920042608.1865560-1-dmitry.torokhov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Sep 19, 2022 at 09:26:05PM -0700, Dmitry Torokhov wrote: > This patch fixes interrupt trigger (should be level low as that is what the > driver is always using), the GPIO that is the interrupt source that is also > used to wake up chip by driving the line low. > > The proper polarity is be needed for converting the driver to gpiod API. > > Signed-off-by: Dmitry Torokhov Looks good to me. Let me know if you want me to pick it up. Otherwise, Acked-by: Shawn Guo Shawn > --- > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 4 ++-- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi > index 1368a4762037..1883350d004e 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi > @@ -451,8 +451,8 @@ touchscreen@4 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_egalax_int>; > interrupt-parent = <&gpio2>; > - interrupts = <28 IRQ_TYPE_EDGE_FALLING>; > - wakeup-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; > + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; > + wakeup-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; > }; > }; > > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index 37482a9023fc..09f4c2fa3ad6 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -311,8 +311,8 @@ touchscreen@4 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_i2c2_egalax_int>; > interrupt-parent = <&gpio6>; > - interrupts = <8 IRQ_TYPE_EDGE_FALLING>; > - wakeup-gpios = <&gpio6 8 GPIO_ACTIVE_HIGH>; > + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; > + wakeup-gpios = <&gpio6 8 GPIO_ACTIVE_LOW>; > }; > > ov5640: camera@3c { > @@ -450,8 +450,8 @@ egalax_ts@4 { > compatible = "eeti,egalax_ts"; > reg = <0x04>; > interrupt-parent = <&gpio6>; > - interrupts = <7 2>; > - wakeup-gpios = <&gpio6 7 0>; > + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; > + wakeup-gpios = <&gpio6 7 GPIO_ACTIVE_LOW>; > }; > > magnetometer@e { > -- > 2.37.3.968.ga6b4b080e4-goog >