From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Bastien Nocera <hadess@hadess.net>,
linux-input@vger.kernel.org
Subject: [PATCH 0/4] Input: touchscreen - Goodix bugfix + settings mod-param support
Date: Tue, 25 Oct 2022 14:29:26 +0200 [thread overview]
Message-ID: <20221025122930.421377-1-hdegoede@redhat.com> (raw)
Hi Dmitry, et al,
The first patch in this set is a bugfix for the Goodix touchscreen driver,
it really is independent of the rest, but since the 4th patch will not
apply cleanly without this I have decided to send this as 1 big series.
If there are issues with the rest of the series please apply at least 1/4.
The rest of the series adds support for overriding various silead and
goodix touchscreen related device-properties from the kernel cmdline.
This is a reposting of an earlier version which had the following
cover letter:
On x86/ACPI platforms touchscreens mostly just work without needing any
device/model specific configuration. But in some cases (mostly with Silead
and Goodix touchscreens) it is still necessary to manually specify various
touchscreen-properties on a per model basis.
This is handled by drivers/platform/x86/touchscreen_dmi.c which contains
a large list of per-model touchscreen properties which it attaches to the
(i2c)device before the touchscreen driver's probe() method gets called.
This means that ATM changing these settings requires recompiling the
kernel. This makes figuring out what settings/properties a specific
touchscreen needs very hard for normal users to do.
This new settings parameter support is especially useful for helping
users to get their Silead touchscreens to work. These need to have
all of their settings (min-x, width, min-y, height, swapping, inverting)
hardcoded in touchscreen_dmi.c. The settings mod-param allows users
to find the right setting without them needing to be capable of
building their own kernel (and without a lot of rebooting) after which
they can ask someone with some kernel-dev experience to turn this into
a touchscreen_dmi.c patch for them (and yes the way this hw works sucks,
but we cannot change that).
An example of a user who was stuck getting their touchscreen to work and
who was helped by providing a kernel with the settings mod-param added:
https://github.com/onitake/gsl-firmware/discussions/193
Regards,
Hans
Hans de Goede (4):
Input: goodix - Try resetting the controller when no config is set
Input: touchscreen - Extend touchscreen_parse_properties() to allow
overriding settings with a module option
Input: silead - Add a settings module-parameter
Input: goodix - Add a settings module-parameter
drivers/input/touchscreen.c | 103 ++++++++++++++++++++++++++---
drivers/input/touchscreen/goodix.c | 18 ++++-
drivers/input/touchscreen/silead.c | 26 +++++---
include/linux/input/touchscreen.h | 19 +++++-
4 files changed, 142 insertions(+), 24 deletions(-)
--
2.37.3
next reply other threads:[~2022-10-25 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 12:29 Hans de Goede [this message]
2022-10-25 12:29 ` [PATCH 1/4] Input: goodix - Try resetting the controller when no config is set Hans de Goede
2022-10-31 14:42 ` Bastien Nocera
2022-10-31 18:18 ` Hans de Goede
2022-11-03 18:32 ` Dmitry Torokhov
2022-10-25 12:29 ` [PATCH 2/4] Input: touchscreen - Extend touchscreen_parse_properties() to allow overriding settings with a module option Hans de Goede
2022-11-03 19:28 ` Dmitry Torokhov
2022-11-28 9:43 ` Hans de Goede
2022-10-25 12:29 ` [PATCH 3/4] Input: silead - Add a settings module-parameter Hans de Goede
2022-10-25 12:29 ` [PATCH 4/4] Input: goodix " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025122930.421377-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).