From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BD0C43219 for ; Sat, 5 Nov 2022 00:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229505AbiKEABm (ORCPT ); Fri, 4 Nov 2022 20:01:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbiKEABh (ORCPT ); Fri, 4 Nov 2022 20:01:37 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7986742F44; Fri, 4 Nov 2022 17:01:36 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2A5015bb068560; Fri, 4 Nov 2022 19:01:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1667606465; bh=70/J8OoLwMz2ZYUbC2R1pWuNjEn/hRSMKPEEuh66w90=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Gv3WplavkR0OhY3cyw5apGFxR8Pf4CI2qe6wRU3/3HFrBUeOEZpOLj8xzHzVACoLa HfODwGrn/JtbF4xchec3d9/wau+CU2O5VbVnZTeCrc1mBQWK3TZP1Zm0vcp3FIEAy7 7bl9h7DVTgXC33YKFhXXlUaKA0MUNVwhVwtcB20I= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2A5014iV084742 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 4 Nov 2022 19:01:04 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Fri, 4 Nov 2022 19:01:04 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Fri, 4 Nov 2022 19:01:04 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2A5014d5015472; Fri, 4 Nov 2022 19:01:04 -0500 Date: Fri, 4 Nov 2022 19:01:04 -0500 From: Nishanth Menon To: jerome Neanne CC: Lee Jones , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Message-ID: <20221105000104.rtj3r6ufqwqmepon@keenly> References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 13:58-20221104, jerome Neanne wrote: > [...] > > > > > Can you try an compile with W=1 please. > This raise one warning on mfd: > drivers/mfd/tps65219.c:28:12: warning: ‘tps65219_soft_shutdown’ defined but > not used [-Wunused-function] > 28 | static int tps65219_soft_shutdown(struct tps65219 *tps) > | ^~~~~~~~~~~~~~~~~~~~~~ > soft_shutdown has been validated and is used in TI baseline even if not > hooked in upstream version further to this review: > https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/ > > It was a TI requirement to implement it... > Let me know if you want me to remove this function or if we can keep it like > this. There are platforms without psci, correct? I think the comment was to drop the force override with system-power-controller property, if (!pm_power_off) { tps65219_i2c_client = client; pm_power_off = &tps65219_pm_power_off; } Could still be valid for such platforms, no? I do see that the capability that the PMIC has - which is software shutdown is a valid feature that we support in many different PMIC drivers. Is'nt the job of the driver to introduce the functionality in a manner that is appropriate to the OS framework? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D