linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
	linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] macintosh/mac_hid.c: don't load by default
Date: Sun, 13 Nov 2022 04:30:22 +0100	[thread overview]
Message-ID: <20221113033022.2639-1-linux@weissschuh.net> (raw)

There should be no need to automatically load this driver on *all*
machines with a keyboard.

This driver is of very limited utility and has to be enabled by the user
explicitly anyway.
Furthermore its own header comment has deprecated it for 17 years.

Fixes: 99b089c3c38a ("Input: Mac button emulation - implement as an input filter")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 drivers/macintosh/mac_hid.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
index d8c4d5664145..d01d28890db4 100644
--- a/drivers/macintosh/mac_hid.c
+++ b/drivers/macintosh/mac_hid.c
@@ -149,8 +149,6 @@ static const struct input_device_id mac_hid_emumouse_ids[] = {
 	{ },
 };
 
-MODULE_DEVICE_TABLE(input, mac_hid_emumouse_ids);
-
 static struct input_handler mac_hid_emumouse_handler = {
 	.filter		= mac_hid_emumouse_filter,
 	.connect	= mac_hid_emumouse_connect,

base-commit: fef7fd48922d11b22620e19f9c9101647bfe943d
-- 
2.38.1


             reply	other threads:[~2022-11-13  3:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13  3:30 Thomas Weißschuh [this message]
2022-11-14 18:33 ` [PATCH] macintosh/mac_hid.c: don't load by default Dmitry Torokhov
2022-11-14 23:54   ` Thomas Weißschuh
2022-11-15  0:16     ` Dmitry Torokhov
2022-11-15  3:07       ` Thomas Weißschuh
2022-11-15  5:41         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221113033022.2639-1-linux@weissschuh.net \
    --to=linux@weissschuh.net \
    --cc=benh@kernel.crashing.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).