* [PATCH RESEND] HID: hid-elan: use default remove for hid device
@ 2022-11-17 12:13 Marcus Folkesson
2022-11-21 21:17 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2022-11-17 12:13 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Marcus Folkesson
Cc: linux-kernel, linux-input
hid_device_remove() will call hid_hw_stop() as default .remove function
if no function is specified.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/hid/hid-elan.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c
index 8e4a5528e25d..76d93fc48f6a 100644
--- a/drivers/hid/hid-elan.c
+++ b/drivers/hid/hid-elan.c
@@ -507,11 +507,6 @@ static int elan_probe(struct hid_device *hdev, const struct hid_device_id *id)
return ret;
}
-static void elan_remove(struct hid_device *hdev)
-{
- hid_hw_stop(hdev);
-}
-
static const struct hid_device_id elan_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_HP_X2),
.driver_data = ELAN_HAS_LED },
@@ -529,7 +524,6 @@ static struct hid_driver elan_driver = {
.input_configured = elan_input_configured,
.raw_event = elan_raw_event,
.probe = elan_probe,
- .remove = elan_remove,
};
module_hid_driver(elan_driver);
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] HID: hid-elan: use default remove for hid device
2022-11-17 12:13 [PATCH RESEND] HID: hid-elan: use default remove for hid device Marcus Folkesson
@ 2022-11-21 21:17 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2022-11-21 21:17 UTC (permalink / raw)
To: Marcus Folkesson; +Cc: Benjamin Tissoires, linux-kernel, linux-input
On Thu, 17 Nov 2022, Marcus Folkesson wrote:
> hid_device_remove() will call hid_hw_stop() as default .remove function
> if no function is specified.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Applied.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17 12:13 [PATCH RESEND] HID: hid-elan: use default remove for hid device Marcus Folkesson
2022-11-21 21:17 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).