From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD534C4167D for ; Thu, 17 Nov 2022 15:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240701AbiKQPVd (ORCPT ); Thu, 17 Nov 2022 10:21:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240316AbiKQPUw (ORCPT ); Thu, 17 Nov 2022 10:20:52 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29C787990D; Thu, 17 Nov 2022 07:17:08 -0800 (PST) Received: from frapeml500004.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4NCk3g38XBz688Z4; Thu, 17 Nov 2022 23:14:39 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by frapeml500004.china.huawei.com (7.182.85.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 16:17:05 +0100 Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 15:17:04 +0000 Date: Thu, 17 Nov 2022 15:17:03 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski CC: Rob Herring , Krzysztof Kozlowski , Andrew Lunn , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH 1/9] dt-bindings: drop redundant part of title of shared bindings Message-ID: <20221117151703.00006bf8@Huawei.com> In-Reply-To: <20221117123850.368213-2-krzysztof.kozlowski@linaro.org> References: <20221117123850.368213-1-krzysztof.kozlowski@linaro.org> <20221117123850.368213-2-krzysztof.kozlowski@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, 17 Nov 2022 13:38:42 +0100 Krzysztof Kozlowski wrote: > The Devicetree bindings document does not have to say in the title that > it is a "binding", but instead just describe the hardware. For shared > (re-usable) schemas, name them all as "common properties". > > Signed-off-by: Krzysztof Kozlowski Acked-by: Jonathan Cameron #for IIO. Looked briefly at the rest and only found the issue Andrew Lunn pointed out. Otherwise all seem fine to me. Jonathan > --- > Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 2 +- > Documentation/devicetree/bindings/dma/dma-common.yaml | 2 +- > Documentation/devicetree/bindings/dma/dma-controller.yaml | 4 ++-- > Documentation/devicetree/bindings/dma/dma-router.yaml | 4 ++-- > Documentation/devicetree/bindings/iio/adc/adc.yaml | 2 +- > .../devicetree/bindings/media/video-interface-devices.yaml | 2 +- > Documentation/devicetree/bindings/media/video-interfaces.yaml | 2 +- > Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +- > Documentation/devicetree/bindings/mtd/nand-chip.yaml | 2 +- > Documentation/devicetree/bindings/mtd/nand-controller.yaml | 2 +- > .../bindings/net/bluetooth/bluetooth-controller.yaml | 2 +- > Documentation/devicetree/bindings/net/can/can-controller.yaml | 2 +- > .../devicetree/bindings/net/ethernet-controller.yaml | 2 +- > Documentation/devicetree/bindings/net/ethernet-phy.yaml | 2 +- > Documentation/devicetree/bindings/net/mdio.yaml | 2 +- > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 +- > .../devicetree/bindings/power/reset/restart-handler.yaml | 2 +- > Documentation/devicetree/bindings/rtc/rtc.yaml | 2 +- > .../devicetree/bindings/soundwire/soundwire-controller.yaml | 2 +- > Documentation/devicetree/bindings/spi/spi-controller.yaml | 2 +- > Documentation/devicetree/bindings/watchdog/watchdog.yaml | 2 +- > 21 files changed, 23 insertions(+), 23 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > index 1ab416c83c8d..d2de3d128b73 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/clock/qcom,gcc.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Qualcomm Global Clock & Reset Controller Common Bindings > +title: Qualcomm Global Clock & Reset Controller common parts > > maintainers: > - Stephen Boyd > diff --git a/Documentation/devicetree/bindings/dma/dma-common.yaml b/Documentation/devicetree/bindings/dma/dma-common.yaml > index ad06d36af208..9b7b94fdbb0b 100644 > --- a/Documentation/devicetree/bindings/dma/dma-common.yaml > +++ b/Documentation/devicetree/bindings/dma/dma-common.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/dma/dma-common.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: DMA Engine Generic Binding > +title: DMA Engine common properties > > maintainers: > - Vinod Koul > diff --git a/Documentation/devicetree/bindings/dma/dma-controller.yaml b/Documentation/devicetree/bindings/dma/dma-controller.yaml > index 6d3727267fa8..225a141c7b5c 100644 > --- a/Documentation/devicetree/bindings/dma/dma-controller.yaml > +++ b/Documentation/devicetree/bindings/dma/dma-controller.yaml > @@ -4,13 +4,13 @@ > $id: http://devicetree.org/schemas/dma/dma-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: DMA Controller Generic Binding > +title: DMA Controller common properties > > maintainers: > - Vinod Koul > > allOf: > - - $ref: "dma-common.yaml#" > + - $ref: dma-common.yaml# > > # Everything else is described in the common file > properties: > diff --git a/Documentation/devicetree/bindings/dma/dma-router.yaml b/Documentation/devicetree/bindings/dma/dma-router.yaml > index 4b817f5dc30e..0ebd7bc6232b 100644 > --- a/Documentation/devicetree/bindings/dma/dma-router.yaml > +++ b/Documentation/devicetree/bindings/dma/dma-router.yaml > @@ -4,13 +4,13 @@ > $id: http://devicetree.org/schemas/dma/dma-router.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: DMA Router Generic Binding > +title: DMA Router common properties > > maintainers: > - Vinod Koul > > allOf: > - - $ref: "dma-common.yaml#" > + - $ref: dma-common.yaml# > > description: > DMA routers are transparent IP blocks used to route DMA request > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml > index db348fcbb52c..bd0f5fae256e 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/iio/adc/adc.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Generic IIO bindings for ADC channels > +title: IIO common properties for ADC channels > > maintainers: > - Jonathan Cameron > diff --git a/Documentation/devicetree/bindings/media/video-interface-devices.yaml b/Documentation/devicetree/bindings/media/video-interface-devices.yaml > index 4527f56a5a6e..bd719cb1813e 100644 > --- a/Documentation/devicetree/bindings/media/video-interface-devices.yaml > +++ b/Documentation/devicetree/bindings/media/video-interface-devices.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/media/video-interface-devices.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Common bindings for video receiver and transmitter devices > +title: Common properties for video receiver and transmitter devices > > maintainers: > - Jacopo Mondi > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml > index 68c3b9871cf3..e8cf73794772 100644 > --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml > +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/media/video-interfaces.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Common bindings for video receiver and transmitter interface endpoints > +title: Common properties for video receiver and transmitter interface endpoints > > maintainers: > - Sakari Ailus > diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > index 802e3ca8be4d..a17f49738abd 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mmc/mmc-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: MMC Controller Generic Binding > +title: MMC Controller common properties > > maintainers: > - Ulf Hansson > diff --git a/Documentation/devicetree/bindings/mtd/nand-chip.yaml b/Documentation/devicetree/bindings/mtd/nand-chip.yaml > index 97ac3a3fbb52..20b195ef9b70 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-chip.yaml > +++ b/Documentation/devicetree/bindings/mtd/nand-chip.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mtd/nand-chip.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: NAND Chip and NAND Controller Generic Binding > +title: NAND Chip and NAND Controller common properties > > maintainers: > - Miquel Raynal > diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > index 359a015d4e5a..a004efc42842 100644 > --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml > +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mtd/nand-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: NAND Chip and NAND Controller Generic Binding > +title: NAND Chip and NAND Controller common properties > > maintainers: > - Miquel Raynal > diff --git a/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml b/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml > index 9309dc40f54f..8715adff5eaf 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/net/bluetooth/bluetooth-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Bluetooth Controller Generic Binding > +title: Bluetooth Controller common properties > > maintainers: > - Marcel Holtmann > diff --git a/Documentation/devicetree/bindings/net/can/can-controller.yaml b/Documentation/devicetree/bindings/net/can/can-controller.yaml > index 1f0e98051074..3747b46cf9b6 100644 > --- a/Documentation/devicetree/bindings/net/can/can-controller.yaml > +++ b/Documentation/devicetree/bindings/net/can/can-controller.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/net/can/can-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: CAN Controller Generic Binding > +title: CAN Controller common properties > > maintainers: > - Marc Kleine-Budde > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index 3aef506fa158..26502c0f2aff 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/net/ethernet-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Ethernet Controller Generic Binding > +title: Ethernet Controller common properties > > maintainers: > - David S. Miller > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index ad808e9ce5b9..0aa1b60e78cc 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/net/ethernet-phy.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Ethernet PHY Generic Binding > +title: Ethernet PHY common properties > > maintainers: > - Andrew Lunn > diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml > index b5706d4e7e38..b184689dd6b2 100644 > --- a/Documentation/devicetree/bindings/net/mdio.yaml > +++ b/Documentation/devicetree/bindings/net/mdio.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/net/mdio.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: MDIO Bus Generic Binding > +title: MDIO Bus common properties > > maintainers: > - Andrew Lunn > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > index cf9c2f7bddc2..20ac432dc683 100644 > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/opp/opp-v2-base.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Generic OPP (Operating Performance Points) Common Binding > +title: Generic OPP (Operating Performance Points) common parts > > maintainers: > - Viresh Kumar > diff --git a/Documentation/devicetree/bindings/power/reset/restart-handler.yaml b/Documentation/devicetree/bindings/power/reset/restart-handler.yaml > index 1f9a2aac53c0..8b52fd156d4c 100644 > --- a/Documentation/devicetree/bindings/power/reset/restart-handler.yaml > +++ b/Documentation/devicetree/bindings/power/reset/restart-handler.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/power/reset/restart-handler.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Restart and shutdown handler generic binding > +title: Restart and shutdown handler common properties > > maintainers: > - Sebastian Reichel > diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml > index 0ec3551f12dd..00848a5a409e 100644 > --- a/Documentation/devicetree/bindings/rtc/rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/rtc.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/rtc/rtc.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: RTC Generic Binding > +title: Real Time Clock common properties > > maintainers: > - Alexandre Belloni > diff --git a/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml b/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml > index 4aad121eff3f..2176033850dc 100644 > --- a/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml > +++ b/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/soundwire/soundwire-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: SoundWire Controller Generic Binding > +title: SoundWire Controller common properties > > maintainers: > - Srinivas Kandagatla > diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml > index 01042a7f382e..6bbe073f894b 100644 > --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/spi/spi-controller.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: SPI Controller Generic Binding > +title: SPI Controller common properties > > maintainers: > - Mark Brown > diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml > index e3dfb02f0ca5..6875cf1c3159 100644 > --- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml > +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/watchdog/watchdog.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Watchdog Generic Bindings > +title: Watchdog common properties > > maintainers: > - Guenter Roeck