* [PATCH hid-next] HID: fix BT_HIDP Kconfig dependencies
@ 2022-11-18 8:42 Benjamin Tissoires
2022-11-21 17:36 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Tissoires @ 2022-11-18 8:42 UTC (permalink / raw)
To: Marcel Holtmann, Jiri Kosina
Cc: linux-bluetooth, linux-input, netdev, linux-kernel,
Benjamin Tissoires, kernel test robot
If HID_SUPPORT is not selected, BT_HIDP should not be available, simply
because we disallowed the HID bus entirely.
Add a new depends and actually revert this file back to where it was 10
years ago before it was changed by commit 1f41a6a99476 ("HID: Fix the
generic Kconfig options").
Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/202211181514.fLhaiS7o-lkp@intel.com/
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
net/bluetooth/hidp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/hidp/Kconfig b/net/bluetooth/hidp/Kconfig
index 14100f341f33..6746be07e222 100644
--- a/net/bluetooth/hidp/Kconfig
+++ b/net/bluetooth/hidp/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config BT_HIDP
tristate "HIDP protocol support"
- depends on BT_BREDR && INPUT
+ depends on BT_BREDR && INPUT && HID_SUPPORT
select HID
help
HIDP (Human Interface Device Protocol) is a transport layer
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH hid-next] HID: fix BT_HIDP Kconfig dependencies
2022-11-18 8:42 [PATCH hid-next] HID: fix BT_HIDP Kconfig dependencies Benjamin Tissoires
@ 2022-11-21 17:36 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2022-11-21 17:36 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Marcel Holtmann, linux-bluetooth, linux-input, netdev,
linux-kernel, kernel test robot
On Fri, 18 Nov 2022, Benjamin Tissoires wrote:
> If HID_SUPPORT is not selected, BT_HIDP should not be available, simply
> because we disallowed the HID bus entirely.
>
> Add a new depends and actually revert this file back to where it was 10
> years ago before it was changed by commit 1f41a6a99476 ("HID: Fix the
> generic Kconfig options").
>
> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/r/202211181514.fLhaiS7o-lkp@intel.com/
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied to for-6.2/hid-bpf.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 17:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18 8:42 [PATCH hid-next] HID: fix BT_HIDP Kconfig dependencies Benjamin Tissoires
2022-11-21 17:36 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).