From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15002C43217 for ; Tue, 22 Nov 2022 07:35:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232389AbiKVHfF (ORCPT ); Tue, 22 Nov 2022 02:35:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbiKVHfD (ORCPT ); Tue, 22 Nov 2022 02:35:03 -0500 X-Greylist: delayed 963 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 21 Nov 2022 23:35:01 PST Received: from smtp15.bhosted.nl (smtp15.bhosted.nl [IPv6:2a02:9e0:8000::26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18E5B1704A for ; Mon, 21 Nov 2022 23:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonic.nl; s=202111; h=content-transfer-encoding:content-type:mime-version:references:in-reply-to: message-id:subject:cc:to:from:date:from; bh=Irzd9p8+2HaCNO0Vn7tqqCeUCmTdBbt/zWJHz9qjP1c=; b=lJrIorXCx0ilwJuwWQE/gouCXs9jdvjGu2hOJkQ4Ozi495WYG+B4K2lUOcPD9V78Zmd7aL2nqx+m5 137Wx+2DAej8WLMp6457IMwMuDJP2u1Ap8bqEZhUXqcOSAFXkialwQAsIPl46fyAGeWrr2HOZICnYZ 7YtkjKhHbW8B3kr4bFX7MtA30XHMPuI/eWCYK0ebioDU1Fx+dpe9pjK97O8EgY6pFXAybWQGLass3C ivcNX99Zo+ifr1rHGo2Xb3ykEb9W5FjAtoCEKZjw8/IixQRLODygQ4r26xKxORp+j11TG3mRAo5gJj FS+4hRfSJpSeIvCpBkvR+mtWSyfXVjQ== X-MSG-ID: ea7fdbdd-6a35-11ed-b61c-0050569d3a82 Date: Tue, 22 Nov 2022 08:18:51 +0100 From: David Jander To: Fabio Estevam Cc: Quentin Schulz , "Angus Ainslie (Purism)" , Shawn Guo , Krzysztof Kozlowski , Heiko Stuebner , Samuel Holland , Bjorn Andersson , Konrad Dybcio , Jernej Skrabec , Bastien Nocera , Chen-Yu Tsai , Sascha Hauer , Pengutronix Kernel Team , Hans de Goede , Andy Gross , Rob Herring , NXP Linux Team , Dmitry Torokhov , Quentin Schulz , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH RFC v2 5/7] arm64: dts: imx: fix touchscreen reset GPIO polarity Message-ID: <20221122081851.6cb762d8@erd992> In-Reply-To: References: <20221103-upstream-goodix-reset-v2-0-2c38fb03a300@theobroma-systems.com> <20221103-upstream-goodix-reset-v2-5-2c38fb03a300@theobroma-systems.com> Organization: Protonic Holland X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, 21 Nov 2022 15:18:32 -0300 Fabio Estevam wrote: > [Adding Angus and David] Thanks. This was apparently necessary ;-) > On Mon, Nov 21, 2022 at 3:12 PM Quentin Schulz wrote: > > > > From: Quentin Schulz > > > > The reset line is active low for the Goodix touchscreen controller so > > let's fix the polarity in the Device Tree node. > > > > Signed-off-by: Quentin Schulz > > --- > > arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts | 2 +- > > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > > index 9fbbbb556c0b3..df7e5ae9698e1 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-prt8mm.dts > > @@ -107,7 +107,7 @@ touchscreeen@5d { > > interrupt-parent = <&gpio1>; > > interrupts = <8 IRQ_TYPE_NONE>; > > irq-gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; > > - reset-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; > > + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; NACK! The PRT8MM has an inverter in the reset line. The reason for that is that the reset line needs to be inactive when the driving side is unpowered. The DT was correct, this change will break it. > > }; > > > > temp-sense@70 { > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > index 6445c6b90b5bb..b038300812b1e 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > @@ -542,7 +542,7 @@ touchscreen@5d { > > pinctrl-0 = <&pinctrl_ts>; > > interrupt-parent = <&gpio3>; > > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > - reset-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>; > > + reset-gpios = <&gpio1 5 GPIO_ACTIVE_LOW>; > > irq-gpios = <&gpio3 0 GPIO_ACTIVE_HIGH>; > > touchscreen-size-x = <720>; > > touchscreen-size-y = <1440>; > > > > -- > > b4 0.10.1 Best regards, -- David Jander Protonic Holland.