From: Eirin Nya <nyanpasu256@gmail.com>
To: "phoenix" <phoenix@emc.com.tw>
Cc: "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"'Josh.Chen'" <josh.chen@emc.com.tw>
Subject: Re: [PATCH V2 3/3] Input: elantech - Fix incorrectly halved touchpad range on ELAN v3 touchpads
Date: Fri, 2 Dec 2022 23:42:06 -0800 [thread overview]
Message-ID: <20221202234206.6527835a.nyanpasu256@gmail.com> (raw)
In-Reply-To: <003201d904ae$05d38870$117a9950$@emc.com.tw>
> If the setting is indeed double resolution, can we simply multiply
> x_max and y_max by 2 instead of re-querying it?
Perhaps in some laptops, x_max or y_max is odd when resolution is
doubled, and rounded up or down in half-resolution mode, so multiplying
the half-resolution size by 2 results in a slightly incorrect full
size. I don't know if that's the case in other touchpads, but my
laptop's touchpad has even size in full-resolution (doubled) mode,
meaning it doesn't round its size in half-resolution mode (so
multiplying both values by 2 would work on my machine).
On Wed, 30 Nov 2022 19:22:25 +0800
"phoenix" <phoenix@emc.com.tw> wrote:
> Consulted with FW team, we suggest re-querying x/y resolution after
> setting absolute mode.
My current patch re-queries x/y resolution after setting absolute mode.
If this is the process that Elan's FW team recommends, should the patch
be kept as-is?
next prev parent reply other threads:[~2022-12-03 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 11:15 [PATCH V2 0/3] Input: Fix incorrectly halved touchpad range on ELAN v3 touchpads Eirin Nya
2022-10-14 11:15 ` [PATCH V2 1/3] Input: elantech - Remove redundant field elantech_data::y_max Eirin Nya
2022-10-14 13:10 ` Mattijs Korpershoek
2022-11-28 9:18 ` Eirin Nya
2022-11-28 13:29 ` Mattijs Korpershoek
2022-11-28 18:01 ` Dmitry Torokhov
2022-10-14 11:15 ` [PATCH V2 2/3] Input: elantech - Remove redundant field elantech_data::width Eirin Nya
2022-10-14 13:14 ` Mattijs Korpershoek
2022-10-14 11:15 ` [PATCH V2 3/3] Input: elantech - Fix incorrectly halved touchpad range on ELAN v3 touchpads Eirin Nya
2022-10-14 13:26 ` Mattijs Korpershoek
2022-11-28 17:57 ` Dmitry Torokhov
2022-11-28 17:58 ` Dmitry Torokhov
2022-11-29 3:47 ` phoenix
2022-11-30 11:22 ` phoenix
2022-12-03 7:42 ` Eirin Nya [this message]
2022-12-05 13:28 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202234206.6527835a.nyanpasu256@gmail.com \
--to=nyanpasu256@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=josh.chen@emc.com.tw \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phoenix@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).