From: Orlando Chamberlain <orlandoch.dev@gmail.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Jiri Kosina" <jikos@kernel.org>,
"jkosina@suse.cz" <jkosina@suse.cz>,
"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
"Andy Shevchenko" <andy@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"ronald@innovation.ch" <ronald@innovation.ch>,
"kekrby@gmail.com" <kekrby@gmail.com>,
"Thomas Weißschuh" <thomas@t-8ch.de>
Subject: Re: [PATCH 0/3] Touch Bar and Keyboard backlight driver for Intel Macs
Date: Fri, 10 Feb 2023 21:47:37 +1100 [thread overview]
Message-ID: <20230210214737.2ef942c6@redecorated-mbp> (raw)
In-Reply-To: <57D52CFB-228D-4071-94CB-D32883BF872A@live.com>
On Fri, 10 Feb 2023 10:41:07 +0000
Aditya Garg <gargaditya08@live.com> wrote:
> >
> > Quick observation. Do you miss the Co-developed-by: tags in the
> > patches?
>
> Most of the changes are minor in the 1st and 2nd patch, we haven't
> changed most of the code. The changes were written as per the
> documentation given in
> https://www.kernel.org/doc/html/latest/maintainer/modifying-patches.html
>
> Do you think a Co-developed-by is still required?
>
> The third patch was actually written by 2 people, so there is a
> Co-developed-by there.
>
To add onto this, for patches 1 and 2, as we haven't been able to
contact the original author (Ronald), I think the only ways we are
allowed to make changes are either doing them in separate patches, or
with the [name <email>: changes] tags. For the latter I thought you had
to do a Signed-off-by after it, but given the changes aren't just to
make the patch apply on a newer version, do you think the
Co-developed-by tag is also needed?
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
>
next prev parent reply other threads:[~2023-02-10 10:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 3:41 [PATCH 0/3] Touch Bar and Keyboard backlight driver for Intel Macs Aditya Garg
2023-02-10 3:43 ` [PATCH 1/3] HID: apple-ibridge: Add Apple iBridge HID driver for T1 chip Aditya Garg
2023-02-10 3:44 ` [PATCH 2/3] HID: apple-touchbar: Add driver for the Touch Bar on MacBook Pros Aditya Garg
2023-02-10 3:45 ` [PATCH 3/3] HID: apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards Aditya Garg
2023-02-10 16:25 ` Thomas Weißschuh
2023-02-10 23:24 ` Orlando Chamberlain
2023-02-11 2:23 ` Thomas Weißschuh
2023-02-11 2:42 ` Thomas Weißschuh
2023-02-11 16:56 ` Pavel Machek
2023-02-12 2:28 ` Orlando Chamberlain
2023-02-12 5:16 ` Aditya Garg
2023-02-12 11:18 ` Andy Shevchenko
2023-02-16 1:17 ` Orlando Chamberlain
2023-02-10 16:13 ` [PATCH 2/3] HID: apple-touchbar: Add driver for the Touch Bar on MacBook Pros Thomas Weißschuh
2023-02-12 11:56 ` Andy Shevchenko
2023-02-10 4:56 ` [PATCH 1/3] HID: apple-ibridge: Add Apple iBridge HID driver for T1 chip Thomas Weißschuh
2023-02-10 8:30 ` Aditya Garg
2023-02-10 8:39 ` Benjamin Tissoires
2023-02-10 8:54 ` Aditya Garg
2023-02-10 9:21 ` Benjamin Tissoires
2023-02-10 12:05 ` Aditya Garg
2023-02-10 12:20 ` Orlando Chamberlain
2023-02-10 13:07 ` Aditya Garg
2023-02-10 14:01 ` Benjamin Tissoires
2023-02-10 15:33 ` Thomas Weißschuh
2023-02-10 15:49 ` Aditya Garg
2023-02-10 18:36 ` Thomas Weißschuh
2023-02-12 11:35 ` Andy Shevchenko
2023-02-10 10:18 ` [PATCH 0/3] Touch Bar and Keyboard backlight driver for Intel Macs Andy Shevchenko
2023-02-10 10:41 ` Aditya Garg
2023-02-10 10:47 ` Orlando Chamberlain [this message]
2023-02-10 11:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210214737.2ef942c6@redecorated-mbp \
--to=orlandoch.dev@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=gargaditya08@live.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=kekrby@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ronald@innovation.ch \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).