From: Danny Kaehn <kaehndan@gmail.com>
To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jikos@kernel.org, benjamin.tissoires@redhat.com
Cc: bartosz.golaszewski@linaro.org,
andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
ethan.twardy@plexus.com
Subject: [PATCH v9 3/3] HID: cp2112: Fwnode Support
Date: Sun, 19 Mar 2023 15:48:02 -0500 [thread overview]
Message-ID: <20230319204802.1364-4-kaehndan@gmail.com> (raw)
In-Reply-To: <20230319204802.1364-1-kaehndan@gmail.com>
Support describing the CP2112's I2C and GPIO interfaces in firmware.
I2C and GPIO child nodes can either be children with names "i2c" and
"gpio", or, for ACPI, device nodes with _ADR Zero and One,
respectively.
Additionally, support configuring the I2C bus speed from the
clock-frequency device property.
Signed-off-by: Danny Kaehn <kaehndan@gmail.com>
---
drivers/hid/hid-cp2112.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index 27cadadda7c9..9e327763fd90 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c
@@ -1234,6 +1234,10 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id)
u8 buf[3];
struct cp2112_smbus_config_report config;
struct gpio_irq_chip *girq;
+ struct i2c_timings timings;
+ struct fwnode_handle *child;
+ u32 addr;
+ const char *name;
int ret;
dev = devm_kzalloc(&hdev->dev, sizeof(*dev), GFP_KERNEL);
@@ -1247,6 +1251,17 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id)
mutex_init(&dev->lock);
+ device_for_each_child_node(&hdev->dev, child) {
+ name = fwnode_get_name(child);
+ ret = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), &addr);
+
+ if ((name && strcmp("i2c", name) == 0) || (!ret && addr == 0))
+ device_set_node(&dev->adap.dev, child);
+ else if ((name && strcmp("gpio", name)) == 0 ||
+ (!ret && addr == 1))
+ dev->gc.fwnode = child;
+ }
+
ret = hid_parse(hdev);
if (ret) {
hid_err(hdev, "parse failed\n");
@@ -1292,6 +1307,9 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id)
goto err_power_normal;
}
+ i2c_parse_fw_timings(&dev->adap.dev, &timings, true);
+
+ config.clock_speed = cpu_to_be32(timings.bus_freq_hz);
config.retry_time = cpu_to_be16(1);
ret = cp2112_hid_output(hdev, (u8 *)&config, sizeof(config),
--
2.25.1
next prev parent reply other threads:[~2023-03-19 20:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 20:47 [PATCH v9 0/3] Firmware Support for USB-HID Devices and CP2112 Danny Kaehn
2023-03-19 20:48 ` [PATCH v9 1/3] dt-bindings: i2c: Add CP2112 HID USB to SMBus Bridge Danny Kaehn
2023-03-20 6:44 ` Krzysztof Kozlowski
2023-03-20 12:25 ` Daniel Kaehn
2023-03-19 20:48 ` [PATCH v9 2/3] HID: usbhid: Share USB device firmware node with child HID device Danny Kaehn
2023-03-19 20:48 ` Danny Kaehn [this message]
2023-03-20 12:58 ` [PATCH v9 3/3] HID: cp2112: Fwnode Support Andy Shevchenko
2023-03-20 13:00 ` Andy Shevchenko
2023-03-20 13:40 ` Daniel Kaehn
2023-03-20 14:05 ` Andy Shevchenko
2023-05-01 23:35 ` Daniel Kaehn
2023-07-03 10:57 ` Andy Shevchenko
2024-01-17 18:48 ` Danny Kaehn
2024-01-18 8:58 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230319204802.1364-4-kaehndan@gmail.com \
--to=kaehndan@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ethan.twardy@plexus.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).