From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16DCC7619A for ; Mon, 20 Mar 2023 00:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229488AbjCTAxG (ORCPT ); Sun, 19 Mar 2023 20:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjCTAxF (ORCPT ); Sun, 19 Mar 2023 20:53:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8E1C19F31; Sun, 19 Mar 2023 17:53:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D63A61151; Mon, 20 Mar 2023 00:53:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D393C4339B; Mon, 20 Mar 2023 00:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679273582; bh=58zc0AzHfesSx+M9pKNJIvOAgE7ILLowXaKun9ELkcg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gIbqgn7k1BUXyI4aG/jajqBB+m2131dIi0ynBiuQJWklwp/Bcyz4IScDw0V+k/Oj+ +OkwWKCRhTSGIM6FmdgVFFY6Ftp2mC/OqwbLOB2QkQpxePvr0jkWboftMBBtMNoxV4 FOFlr2vad3XNmUKswVMBCytiggQc/u+1BcuwBxucdxVnyDQPXAjkTlqWspHNx5bLPl V1VrF74cirVSj/84YsPIE0+NEZ3vLq69xAeR59HRWi847vuMrLkTawp0ANLbqeXQJG +qiBmrtq61YZtAdL9GB5ISKUmOfBDjypeovHF0PoxOArlR39PzhhSfkb9XXu2s2WBR OnRUrrykCL7SA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Danny Kaehn , Benjamin Tissoires , Sasha Levin , jikos@kernel.org, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 6.2 02/30] HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded Date: Sun, 19 Mar 2023 20:52:27 -0400 Message-Id: <20230320005258.1428043-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320005258.1428043-1-sashal@kernel.org> References: <20230320005258.1428043-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Danny Kaehn [ Upstream commit 37f5b858a66543b2b67c0288280af623985abc29 ] The CP2112 generates interrupts from a polling routine on a thread, and can only support threaded interrupts. This patch configures the gpiochip irq chip with this flag, disallowing consumers to request a hard IRQ from this driver, which resulted in a segfault previously. Signed-off-by: Danny Kaehn Link: https://lore.kernel.org/r/20230210170044.11835-1-kaehndan@gmail.com Signed-off-by: Benjamin Tissoires Signed-off-by: Sasha Levin --- drivers/hid/hid-cp2112.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 1e16b0fa310d1..27cadadda7c9d 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -1354,6 +1354,7 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) girq->parents = NULL; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_simple_irq; + girq->threaded = true; ret = gpiochip_add_data(&dev->gc, dev); if (ret < 0) { -- 2.39.2