* [PATCH] Input: cyttsp5 - fix sensing configuration data structure
@ 2023-04-11 21:16 hrdl
2023-04-12 11:06 ` Alistair
2023-04-14 6:41 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: hrdl @ 2023-04-11 21:16 UTC (permalink / raw)
To: Linus Walleij, Dmitry Torokhov
Cc: linux-input, linux-kernel, Alistair Francis, hrdl
Prior to this patch, the sensing configuration data was not parsed
correctly, breaking detection of max_tch. The vendor driver includes
this field. This change informs the driver about the correct maximum
number of simultaneous touch inputs.
Tested on a Pine64 PineNote with a modified touch screen controller
firmware.
Signed-off-by: hrdl <git@hrdl.eu>
---
drivers/input/touchscreen/cyttsp5.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
index 16caffa35dd9..30102cb80fac 100644
--- a/drivers/input/touchscreen/cyttsp5.c
+++ b/drivers/input/touchscreen/cyttsp5.c
@@ -111,6 +111,7 @@ struct cyttsp5_sensing_conf_data_dev {
__le16 max_z;
u8 origin_x;
u8 origin_y;
+ u8 panel_id;
u8 btn;
u8 scan_mode;
u8 max_num_of_tch_per_refresh_cycle;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: cyttsp5 - fix sensing configuration data structure
2023-04-11 21:16 [PATCH] Input: cyttsp5 - fix sensing configuration data structure hrdl
@ 2023-04-12 11:06 ` Alistair
2023-04-14 6:41 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Alistair @ 2023-04-12 11:06 UTC (permalink / raw)
To: hrdl, Linus Walleij, Dmitry Torokhov
Cc: linux-input, Linux Kernel Mailing List
On Wed, 12 Apr 2023, at 7:16 AM, hrdl wrote:
> Prior to this patch, the sensing configuration data was not parsed
> correctly, breaking detection of max_tch. The vendor driver includes
> this field. This change informs the driver about the correct maximum
> number of simultaneous touch inputs.
>
> Tested on a Pine64 PineNote with a modified touch screen controller
> firmware.
>
> Signed-off-by: hrdl <git@hrdl.eu>
Reviewed-by: Alistair Francis <alistair@alistair23.me>
Alistair
> ---
> drivers/input/touchscreen/cyttsp5.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> index 16caffa35dd9..30102cb80fac 100644
> --- a/drivers/input/touchscreen/cyttsp5.c
> +++ b/drivers/input/touchscreen/cyttsp5.c
> @@ -111,6 +111,7 @@ struct cyttsp5_sensing_conf_data_dev {
> __le16 max_z;
> u8 origin_x;
> u8 origin_y;
> + u8 panel_id;
> u8 btn;
> u8 scan_mode;
> u8 max_num_of_tch_per_refresh_cycle;
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Input: cyttsp5 - fix sensing configuration data structure
2023-04-11 21:16 [PATCH] Input: cyttsp5 - fix sensing configuration data structure hrdl
2023-04-12 11:06 ` Alistair
@ 2023-04-14 6:41 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2023-04-14 6:41 UTC (permalink / raw)
To: hrdl; +Cc: Linus Walleij, linux-input, linux-kernel, Alistair Francis
On Tue, Apr 11, 2023 at 11:16:51PM +0200, hrdl wrote:
> Prior to this patch, the sensing configuration data was not parsed
> correctly, breaking detection of max_tch. The vendor driver includes
> this field. This change informs the driver about the correct maximum
> number of simultaneous touch inputs.
>
> Tested on a Pine64 PineNote with a modified touch screen controller
> firmware.
>
> Signed-off-by: hrdl <git@hrdl.eu>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-14 6:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-11 21:16 [PATCH] Input: cyttsp5 - fix sensing configuration data structure hrdl
2023-04-12 11:06 ` Alistair
2023-04-14 6:41 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).