From: Maximilian Weigand <mweigand2017@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Maximilian Weigand <mweigand@mweigand.net>,
Alistair Francis <alistair@alistair23.me>
Subject: [PATCH v3 0/1] Small fixes to the cyttsp5 touchscreen driver
Date: Thu, 4 May 2023 14:03:15 +0200 [thread overview]
Message-ID: <20230504120316.408687-1-mweigand2017@gmail.com> (raw)
From: Maximilian Weigand <mweigand@mweigand.net>
Currently the cyttsp5 driver does not put the device to sleep during
suspend, which can have unwanted side effects if an irq trigger of type
EDGE_FALLING is used, as well as leads to increased power usage.
Correspondingly, sleep and wakeup commands to the touchscreen were
derived from the GPL-2 vendor/android driver by Cypress Semiconductor
(copyright note for Cypress Semiconductor is already in the current
driver).
Tested on the Pine64 PineNote.
Changes in v3:
- dropped patches 1,2,5: already applied in v2
- dropped patch 4 "Input: cyttsp5 - properly initialize the device as a
pm wakeup device" - functionality is already taken care of in the
kernel
- dropped patch 3 "dt-bindings: input: cypress,tt21000 - fix interrupt
type in dts example": it was suggested that the driver should work
with both interrupt types, falling edge and level low. Once a solution
is found it will be submitted as a separate patch.
- reworked patch 6 "Input: cyttsp5 - implement proper sleep and wakeup
procedures" in response to review comments:
- use the existing completion instead of adding a new one for
sleep/wakeup command handling
- use device_may_wakeup() to determine if the device should be
suspended upon entering standby
- clarified commit message
Changes in v2:
- fix subject lines
- fix 'unused variable' errors reported by the kernel test robot
- clean up commit message of patch 2
Maximilian Weigand (1):
Input: cyttsp5 - implement proper sleep and wakeup procedures
drivers/input/touchscreen/cyttsp5.c | 118 ++++++++++++++++++++++++++++
1 file changed, 118 insertions(+)
base-commit: 457391b0380335d5e9a5babdec90ac53928b23b4
--
2.39.2
next reply other threads:[~2023-05-04 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 12:03 Maximilian Weigand [this message]
2023-05-04 12:03 ` [PATCH v3 1/1] Input: cyttsp5 - implement proper sleep and wakeup procedures Maximilian Weigand
2023-05-05 18:48 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504120316.408687-1-mweigand2017@gmail.com \
--to=mweigand2017@gmail.com \
--cc=alistair@alistair23.me \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mweigand@mweigand.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).