linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: kernel@pengutronix.de, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: Switch i2c drivers back to use .probe()
Date: Fri, 26 May 2023 17:56:47 +0200	[thread overview]
Message-ID: <20230526155647.vanaz65gkmo3ffgy@pengutronix.de> (raw)
In-Reply-To: <ZGUImQNUL9uNNHmO@google.com>

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

Hello Dmitry,

On Wed, May 17, 2023 at 10:02:17AM -0700, Dmitry Torokhov wrote:
> On Wed, May 17, 2023 at 06:46:45PM +0200, Uwe Kleine-König wrote:
> > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> > call-back type"), all drivers being converted to .probe_new() and then
> > 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> > back to (the new) .probe() to be able to eventually drop .probe_new() from
> > struct i2c_driver.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> > 
> > this patch was generated using coccinelle, but I aligned the result to
> > the per-file indention. Other than that it's just s/probe_new/probe/.
> > 
> > I used v6.4-rc1 as base for it, there are a few patches in next that
> > conflict slightly with it, but for me git can sort it all out.
> > Feel free to just drop all conflicting hunks if it doesn't go so smooth
> > for you, I'll care about the fallout later.
> 
> I think I saw only 1 clash in cyttsp5 driver, and I resolved it.
> Hopefully I did not miss anything else.
> 
> This is now applied for the next merge window.

FTR: Looking at commit d8bde56dfd86 ("Input: Switch i2c drivers back to
use .probe()") which is in next-20230525, everything seems to be right.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2023-05-26 15:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 16:46 [PATCH] Input: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-17 17:02 ` Dmitry Torokhov
2023-05-26 15:56   ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230526155647.vanaz65gkmo3ffgy@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).