* [PATCH] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
@ 2023-06-29 19:24 Stuart Hayhurst
2023-06-29 20:00 ` Bastien Nocera
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Stuart Hayhurst @ 2023-06-29 19:24 UTC (permalink / raw)
Cc: Stuart Hayhurst, linux-kernel, linux-input, Benjamin Tissoires,
Jiri Kosina, Bastien Nocera, Filipe Laíns
Previously, support for the G502 had been attempted and reverted within this driver.
Since then, a new version of this mouse has been released, and seems to work fine.
Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
---
drivers/hid/hid-logitech-hidpp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 5e1a412fd28f..050bad0f9aca 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4598,6 +4598,8 @@ static const struct hid_device_id hidpp_devices[] = {
{ /* Logitech G403 Wireless Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
+ { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
{ /* Logitech G703 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
{ /* Logitech G703 Hero Gaming Mouse over USB */
--
2.40.1.521.gf1e218fcd8
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
2023-06-29 19:24 [PATCH] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed Stuart Hayhurst
@ 2023-06-29 20:00 ` Bastien Nocera
2023-06-29 21:40 ` Stuart Hayhurst
2023-06-29 21:46 ` [PATCH v2] " Stuart Hayhurst
2 siblings, 0 replies; 5+ messages in thread
From: Bastien Nocera @ 2023-06-29 20:00 UTC (permalink / raw)
To: Stuart Hayhurst
Cc: linux-kernel, linux-input, Benjamin Tissoires, Jiri Kosina,
Filipe Laíns
On Thu, 2023-06-29 at 20:24 +0100, Stuart Hayhurst wrote:
> Previously, support for the G502 had been attempted and reverted
> within this driver.
Can you please mention the commit(s) where this was done?
> Since then, a new version of this mouse has been released, and seems
> to work fine.
Can you please list the features that get enabled by adding this USB ID
to the list in the commit message?
Cheers
>
> Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
> ---
> drivers/hid/hid-logitech-hidpp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 5e1a412fd28f..050bad0f9aca 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4598,6 +4598,8 @@ static const struct hid_device_id
> hidpp_devices[] = {
>
> { /* Logitech G403 Wireless Gaming Mouse over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
> + { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB
> */
> + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
> { /* Logitech G703 Gaming Mouse over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
> { /* Logitech G703 Hero Gaming Mouse over USB */
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
2023-06-29 19:24 [PATCH] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed Stuart Hayhurst
2023-06-29 20:00 ` Bastien Nocera
@ 2023-06-29 21:40 ` Stuart Hayhurst
2023-06-29 21:46 ` [PATCH v2] " Stuart Hayhurst
2 siblings, 0 replies; 5+ messages in thread
From: Stuart Hayhurst @ 2023-06-29 21:40 UTC (permalink / raw)
Cc: Stuart Hayhurst, linux-kernel, linux-input, Benjamin Tissoires,
Jiri Kosina, Bastien Nocera, Filipe Laíns
Previously, support for the G502 had been attempted in commit 27fc32f.
This caused some issues and was reverted by addf338.
Since then, a new version of this mouse has been released (Lightpseed Wireless), and works correctly.
This device has support for battery reporting with the driver
Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
---
drivers/hid/hid-logitech-hidpp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 5e1a412fd28f..94a045ef8e50 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4598,6 +4598,8 @@ static const struct hid_device_id hidpp_devices[] = {
{ /* Logitech G403 Wireless Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
+ { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
{ /* Logitech G703 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
{ /* Logitech G703 Hero Gaming Mouse over USB */
--
2.40.1.521.gf1e218fcd8
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
2023-06-29 19:24 [PATCH] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed Stuart Hayhurst
2023-06-29 20:00 ` Bastien Nocera
2023-06-29 21:40 ` Stuart Hayhurst
@ 2023-06-29 21:46 ` Stuart Hayhurst
2023-06-30 11:13 ` Bastien Nocera
2 siblings, 1 reply; 5+ messages in thread
From: Stuart Hayhurst @ 2023-06-29 21:46 UTC (permalink / raw)
Cc: Stuart Hayhurst, linux-kernel, linux-input, Benjamin Tissoires,
Jiri Kosina, Bastien Nocera, Filipe Laíns
Previously, support for the G502 had been attempted in commit 27fc32f.
This caused some issues and was reverted by addf338.
Since then, a new version of this mouse has been released (Lightpseed Wireless), and works correctly.
This device has support for battery reporting with the driver
Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
---
drivers/hid/hid-logitech-hidpp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 5e1a412fd28f..94a045ef8e50 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -4598,6 +4598,8 @@ static const struct hid_device_id hidpp_devices[] = {
{ /* Logitech G403 Wireless Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
+ { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB */
+ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
{ /* Logitech G703 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
{ /* Logitech G703 Hero Gaming Mouse over USB */
--
2.40.1.521.gf1e218fcd8
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed
2023-06-29 21:46 ` [PATCH v2] " Stuart Hayhurst
@ 2023-06-30 11:13 ` Bastien Nocera
0 siblings, 0 replies; 5+ messages in thread
From: Bastien Nocera @ 2023-06-30 11:13 UTC (permalink / raw)
To: Stuart Hayhurst
Cc: linux-kernel, linux-input, Benjamin Tissoires, Jiri Kosina,
Filipe Laíns
On Thu, 2023-06-29 at 22:46 +0100, Stuart Hayhurst wrote:
> Previously, support for the G502 had been attempted in commit
> 27fc32f.
> This caused some issues and was reverted by addf338.
> Since then, a new version of this mouse has been released (Lightpseed
> Wireless), and works correctly.
Sorry to do this to you, but you might need to rework the description
again. The kernel maintainers are pretty strict when it comes to commit
references.
"If you want to refer to a specific commit, don't just refer to the
SHA-1 ID of the commit. Please also include the oneline summary of the
commit, to make it easier for reviewers to know what it is about."
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
So 12-character short SHA-1 and the subject of the commit.
./scripts/checkpatch.pl should warn about that.
Should be:
27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more
supported mice"
and
addf3382c47c ("Revert "HID: logitech-hidpp: add USB PID for a few more
supported mice"")
But you'll want to check those :)
>
> This device has support for battery reporting with the driver
>
> Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
> ---
> drivers/hid/hid-logitech-hidpp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 5e1a412fd28f..94a045ef8e50 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4598,6 +4598,8 @@ static const struct hid_device_id
> hidpp_devices[] = {
>
> { /* Logitech G403 Wireless Gaming Mouse over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
> + { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB
> */
> + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
> { /* Logitech G703 Gaming Mouse over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
> { /* Logitech G703 Hero Gaming Mouse over USB */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-30 11:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-29 19:24 [PATCH] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed Stuart Hayhurst
2023-06-29 20:00 ` Bastien Nocera
2023-06-29 21:40 ` Stuart Hayhurst
2023-06-29 21:46 ` [PATCH v2] " Stuart Hayhurst
2023-06-30 11:13 ` Bastien Nocera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).