linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com
Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	linux-input@vger.kernel.org, linux-media@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-geode@lists.infradead.org,
	linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org,
	linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH 04/17] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers
Date: Mon, 10 Jul 2023 14:50:08 +0200	[thread overview]
Message-ID: <20230710130113.14563-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de>

The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by devm_kzalloc(). So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurences of FBINFO_DEFAULT, the token can be removed.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Helge Deller <deller@gmx.de>
---
 drivers/video/fbdev/pxafb.c    | 1 -
 drivers/video/fbdev/sa1100fb.c | 1 -
 drivers/video/fbdev/wm8505fb.c | 3 +--
 drivers/video/fbdev/xilinxfb.c | 1 -
 4 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 2a8b1dea3a67..c8c4677d06b4 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -1826,7 +1826,6 @@ static struct pxafb_info *pxafb_init_fbinfo(struct device *dev,
 	fbi->fb.var.vmode	= FB_VMODE_NONINTERLACED;
 
 	fbi->fb.fbops		= &pxafb_ops;
-	fbi->fb.flags		= FBINFO_DEFAULT;
 	fbi->fb.node		= -1;
 
 	addr = fbi;
diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
index a2408bf00ca0..3d76ce111488 100644
--- a/drivers/video/fbdev/sa1100fb.c
+++ b/drivers/video/fbdev/sa1100fb.c
@@ -1089,7 +1089,6 @@ static struct sa1100fb_info *sa1100fb_init_fbinfo(struct device *dev)
 	fbi->fb.var.vmode	= FB_VMODE_NONINTERLACED;
 
 	fbi->fb.fbops		= &sa1100fb_ops;
-	fbi->fb.flags		= FBINFO_DEFAULT;
 	fbi->fb.monspecs	= monspecs;
 	fbi->fb.pseudo_palette	= fbi->pseudo_palette;
 
diff --git a/drivers/video/fbdev/wm8505fb.c b/drivers/video/fbdev/wm8505fb.c
index 10a8b1250103..5833147aa43d 100644
--- a/drivers/video/fbdev/wm8505fb.c
+++ b/drivers/video/fbdev/wm8505fb.c
@@ -285,8 +285,7 @@ static int wm8505fb_probe(struct platform_device *pdev)
 	fbi->fb.fix.accel	= FB_ACCEL_NONE;
 
 	fbi->fb.fbops		= &wm8505fb_ops;
-	fbi->fb.flags		= FBINFO_DEFAULT
-				| FBINFO_HWACCEL_COPYAREA
+	fbi->fb.flags		= FBINFO_HWACCEL_COPYAREA
 				| FBINFO_HWACCEL_FILLRECT
 				| FBINFO_HWACCEL_XPAN
 				| FBINFO_HWACCEL_YPAN
diff --git a/drivers/video/fbdev/xilinxfb.c b/drivers/video/fbdev/xilinxfb.c
index 2aa3a528277f..768a281a8d2c 100644
--- a/drivers/video/fbdev/xilinxfb.c
+++ b/drivers/video/fbdev/xilinxfb.c
@@ -324,7 +324,6 @@ static int xilinxfb_assign(struct platform_device *pdev,
 	drvdata->info.fix.line_length = pdata->xvirt * BYTES_PER_PIXEL;
 
 	drvdata->info.pseudo_palette = drvdata->pseudo_palette;
-	drvdata->info.flags = FBINFO_DEFAULT;
 	drvdata->info.var = xilinx_fb_var;
 	drvdata->info.var.height = pdata->screen_height_mm;
 	drvdata->info.var.width = pdata->screen_width_mm;
-- 
2.41.0


  parent reply	other threads:[~2023-07-10 13:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 12:50 [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 01/17] drm: Remove flag FBINFO_DEFAULT from fbdev emulation Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 02/17] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 03/17] " Thomas Zimmermann
2023-07-10 12:50 ` Thomas Zimmermann [this message]
2023-07-10 12:50 ` [PATCH 05/17] " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 06/17] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 07/17] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 08/17] arch/sh: Do not assign FBINFO_FLAG_DEFAULT to fb_videomode.flag Thomas Zimmermann
2023-07-10 13:42   ` John Paul Adrian Glaubitz
2023-07-10 13:52     ` Thomas Zimmermann
2023-07-10 13:59       ` John Paul Adrian Glaubitz
2023-07-10 14:04         ` Thomas Zimmermann
2023-07-10 14:08           ` John Paul Adrian Glaubitz
2023-07-10 12:50 ` [PATCH 09/17] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 14:24   ` Miguel Ojeda
2023-07-10 15:22     ` Thomas Zimmermann
2023-07-10 16:25       ` Miguel Ojeda
2023-07-11  6:10         ` Thomas Zimmermann
2023-07-11 10:03           ` Miguel Ojeda
2023-07-10 12:50 ` [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Thomas Zimmermann
2023-07-10 13:05   ` Benjamin Tissoires
2023-07-12  9:43   ` Bruno Prémont
2023-07-10 12:50 ` [PATCH 11/17] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 12/17] staging: " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 13/17] fbdev: " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 14/17] " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 15/17] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 16/17] fbdev/pxafb: " Thomas Zimmermann
2023-07-10 12:50 ` [PATCH 17/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-10 17:19 ` [PATCH 00/17] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Sam Ravnborg
2023-07-11  6:24   ` Thomas Zimmermann
2023-07-11 14:47     ` Sam Ravnborg
2023-07-11 15:24       ` Helge Deller
2023-07-11 16:04         ` Geert Uytterhoeven
2023-07-12  6:44       ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710130113.14563-5-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-nvidia@lists.surfsouth.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).