From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com, geert@linux-m68k.org,
dan.carpenter@linaro.org
Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-input@vger.kernel.org, linux-media@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-geode@lists.infradead.org, linux-hyperv@vger.kernel.org,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>,
Sam Ravnborg <sam@ravnborg.org>, Miguel Ojeda <ojeda@kernel.org>,
Robin van der Gracht <robin@protonic.nl>
Subject: [PATCH v4 09/18] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
Date: Sat, 15 Jul 2023 20:51:51 +0200 [thread overview]
Message-ID: <20230715185343.7193-10-tzimmermann@suse.de> (raw)
In-Reply-To: <20230715185343.7193-1-tzimmermann@suse.de>
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.
Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Miguel Ojeda <ojeda@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Robin van der Gracht <robin@protonic.nl>
---
drivers/auxdisplay/cfag12864bfb.c | 1 -
drivers/auxdisplay/ht16k33.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag12864bfb.c
index c2cab7e2b126..729845bcc803 100644
--- a/drivers/auxdisplay/cfag12864bfb.c
+++ b/drivers/auxdisplay/cfag12864bfb.c
@@ -79,7 +79,6 @@ static int cfag12864bfb_probe(struct platform_device *device)
info->var = cfag12864bfb_var;
info->pseudo_palette = NULL;
info->par = NULL;
- info->flags = FBINFO_FLAG_DEFAULT;
if (register_framebuffer(info) < 0)
goto fballoced;
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index edaf92b7ea77..df3f37651e45 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -646,7 +646,6 @@ static int ht16k33_fbdev_probe(struct device *dev, struct ht16k33_priv *priv,
fbdev->info->var = ht16k33_fb_var;
fbdev->info->bl_dev = bl;
fbdev->info->pseudo_palette = NULL;
- fbdev->info->flags = FBINFO_FLAG_DEFAULT;
fbdev->info->par = priv;
err = register_framebuffer(fbdev->info);
--
2.41.0
next prev parent reply other threads:[~2023-07-15 18:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 18:51 [PATCH v4 00/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 01/18] drm: Remove flag FBINFO_DEFAULT from fbdev emulation Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 02/18] fbdev: Remove FBINFO_DEFAULT from static structs Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 03/18] fbdev: Remove FBINFO_DEFAULT from kzalloc()'ed structs Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 04/18] fbdev: Remove FBINFO_DEFAULT from devm_kzalloc()'ed structs Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 05/18] fbdev: Remove FBINFO_DEFAULT from framebuffer_alloc()'ed structs Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 06/18] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 07/18] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 08/18] sh: mach-sh7763rdp: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag Thomas Zimmermann
2023-07-15 18:51 ` Thomas Zimmermann [this message]
2023-07-15 18:51 ` [PATCH v4 10/18] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-18 10:58 ` Hans Verkuil
2023-07-15 18:51 ` [PATCH v4 12/18] staging: " Thomas Zimmermann
2023-07-16 5:39 ` Greg Kroah-Hartman
2023-07-15 18:51 ` [PATCH v4 13/18] fbdev: Remove FBINFO_FLAG_DEFAULT from kzalloc()'ed structs Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 14/18] fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structs Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 15/18] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 16/18] fbdev/pxafb: " Thomas Zimmermann
2023-07-15 18:51 ` [PATCH v4 17/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-15 18:52 ` [PATCH v4 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230715185343.7193-10-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dan.carpenter@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ojeda@kernel.org \
--cc=robin@protonic.nl \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).