From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Giulio Benetti <giulio.benetti@benettiengineering.com>
Subject: [PATCH 12/22] Input: hycon-hy46xx - use device core to create driver-specific device attributes
Date: Fri, 28 Jul 2023 17:51:21 -0700 [thread overview]
Message-ID: <20230729005133.1095051-12-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20230729005133.1095051-1-dmitry.torokhov@gmail.com>
Instead of creating driver-specific device attributes with
devm_device_add_group() have device core do this by setting up dev_groups
pointer in the driver structure.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/hycon-hy46xx.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/input/touchscreen/hycon-hy46xx.c b/drivers/input/touchscreen/hycon-hy46xx.c
index 2450cfa14de9..d0f257989fd6 100644
--- a/drivers/input/touchscreen/hycon-hy46xx.c
+++ b/drivers/input/touchscreen/hycon-hy46xx.c
@@ -274,10 +274,7 @@ static struct attribute *hycon_hy46xx_attrs[] = {
&hycon_hy46xx_attr_bootloader_version.dattr.attr,
NULL
};
-
-static const struct attribute_group hycon_hy46xx_attr_group = {
- .attrs = hycon_hy46xx_attrs,
-};
+ATTRIBUTE_GROUPS(hycon_hy46xx);
static void hycon_hy46xx_get_defaults(struct device *dev, struct hycon_hy46xx_data *tsdata)
{
@@ -535,10 +532,6 @@ static int hycon_hy46xx_probe(struct i2c_client *client)
return error;
}
- error = devm_device_add_group(&client->dev, &hycon_hy46xx_attr_group);
- if (error)
- return error;
-
error = input_register_device(input);
if (error)
return error;
@@ -576,6 +569,7 @@ MODULE_DEVICE_TABLE(of, hycon_hy46xx_of_match);
static struct i2c_driver hycon_hy46xx_driver = {
.driver = {
.name = "hycon_hy46xx",
+ .dev_groups = hycon_hy46xx_groups,
.of_match_table = hycon_hy46xx_of_match,
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
--
2.41.0.487.g6d72f3e995-goog
next prev parent reply other threads:[~2023-07-29 0:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 0:51 [PATCH 01/22] Input: cros_ec_keyb - use device core to create driver-specific device attributes Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 02/22] Input: cyapa " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 03/22] Input: iqs269a " Dmitry Torokhov
2023-07-31 15:41 ` Jeff LaBundy
2023-08-02 13:01 ` Mattijs Korpershoek
2023-07-29 0:51 ` [PATCH 04/22] Input: kxtj9 " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 05/22] Input: ad7877 " Dmitry Torokhov
2023-07-31 5:23 ` Hennerich, Michael
2023-07-29 0:51 ` [PATCH 06/22] Input: ad7879 " Dmitry Torokhov
2023-07-31 5:23 ` Hennerich, Michael
2023-07-29 0:51 ` [PATCH 07/22] Input: ads7846 " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 08/22] Input: edt-ft5x06 " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 09/22] Input: elants_i2c " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 10/22] Input: exc3000 " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 11/22] Input: hideep " Dmitry Torokhov
2023-07-29 0:51 ` Dmitry Torokhov [this message]
2023-07-29 0:51 ` [PATCH 13/22] Input: ili210x " Dmitry Torokhov
2023-07-29 15:07 ` Marek Vasut
2023-07-30 11:38 ` Greg Kroah-Hartman
2023-07-30 12:24 ` Marek Vasut
2023-07-29 0:51 ` [PATCH 14/22] Input: ilitek_ts_i2c " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 15/22] Input: iqs5xx " Dmitry Torokhov
2023-07-31 15:43 ` Jeff LaBundy
2023-07-29 0:51 ` [PATCH 16/22] Input: melfas-mip4 " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 17/22] Input: raydium_i2c_ts " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 18/22] Input: rohm_bu21023 " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 19/22] Input: s6sy761 " Dmitry Torokhov
2023-07-30 13:02 ` Andi Shyti
2023-07-29 0:51 ` [PATCH 20/22] Input: stmfts " Dmitry Torokhov
2023-07-30 13:02 ` Andi Shyti
2023-07-29 0:51 ` [PATCH 21/22] Input: tsc2004/5 " Dmitry Torokhov
2023-07-29 0:51 ` [PATCH 22/22] Input: wdt87xx_i2c " Dmitry Torokhov
2023-07-29 2:40 ` [PATCH 01/22] Input: cros_ec_keyb " Guenter Roeck
2023-07-30 11:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230729005133.1095051-12-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).