linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Roith <johannes@gnu-linux.rocks>
To: christophe.jaillet@wanadoo.fr
Cc: andi.shyti@kernel.org, benjamin.tissoires@redhat.com,
	jikos@kernel.org, johannes@gnu-linux.rocks,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	ak@it-klinger.de
Subject: Re: [PATCH] hid-mcp2200: added driver for GPIOs of MCP2200
Date: Sun, 30 Jul 2023 21:37:12 +0200	[thread overview]
Message-ID: <20230730193712.379694-1-johannes@gnu-linux.rocks> (raw)
In-Reply-To: <df1acc44-62c3-1ac6-103e-561baf8e38e4@wanadoo.fr>

Hello Andi, hello Christophe,

thanks for the feedback and the hints. I will add most of your suggestions to
the driver and submit a new patch, this time with a correct Version Label.

I need to use dynamic memory allocation for the data passed to 
hid_hw_output_report, overwise the function doesn't work, 0 bytes will be sent.
The memory has to be allocated dynamically because of the DMA usage in the
background. 

But all the over feedback looks good and will be added to the driver.

Best regards,
Johannes

  reply	other threads:[~2023-07-30 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 11:01 [PATCH] hid-mcp2200: added driver for GPIOs of MCP2200 Johannes Roith
2023-07-27 22:03 ` Andi Shyti
2023-07-27 22:30 ` Christophe JAILLET
2023-07-30 19:37   ` Johannes Roith [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-06-15 18:30 Johannes Roith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230730193712.379694-1-johannes@gnu-linux.rocks \
    --to=johannes@gnu-linux.rocks \
    --cc=ak@it-klinger.de \
    --cc=andi.shyti@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).