[PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"

[PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"

[Sebastian Wick]

This reverts commit 7984b43542070f5888546d95b48003c4a8af7c0f to make the
touchpad usable again.

Tapping does not generate any events for user space and moving the
cursor is janky. Disabling InterTouch fixes those issues.

Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com>
---
 drivers/input/mouse/synaptics.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index ada299ec5bba..0e01df88cf69 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -182,7 +182,6 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
 	"LEN009b", /* T580 */
 	"LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
-	"LEN040f", /* P1 Gen 3 */
 	"LEN200f", /* T450s */
 	"LEN2044", /* L470  */
 	"LEN2054", /* E480 */
-- 
2.41.0

Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"

[Lyude Paul]

Hm, This looks fine to me (if not as a final fix, certainly as a workaround)

Reviewed-by: Lyude Paul <lyude@redhat.com>

However, this is definitely something we probably should try to fix at some
point - as I imagine this must be happening because something regarding how
clicks are reported must have changed again. Andrew, do you have any idea?

On Tue, 2023-08-08 at 17:28 +0200, Sebastian Wick wrote:
> This reverts commit 7984b43542070f5888546d95b48003c4a8af7c0f to make the
> touchpad usable again.
> 
> Tapping does not generate any events for user space and moving the
> cursor is janky. Disabling InterTouch fixes those issues.
> 
> Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com>
> ---
>  drivers/input/mouse/synaptics.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index ada299ec5bba..0e01df88cf69 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -182,7 +182,6 @@ static const char * const smbus_pnp_ids[] = {
>  	"LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
>  	"LEN009b", /* T580 */
>  	"LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
> -	"LEN040f", /* P1 Gen 3 */
>  	"LEN200f", /* T450s */
>  	"LEN2044", /* L470  */
>  	"LEN2054", /* E480 */

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat

Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"

[Dmitry Torokhov]

On Tue, Aug 08, 2023 at 05:49:23PM -0400, Lyude Paul wrote:
> Hm, This looks fine to me (if not as a final fix, certainly as a workaround)
> 
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> 
> However, this is definitely something we probably should try to fix at some
> point - as I imagine this must be happening because something regarding how
> clicks are reported must have changed again. Andrew, do you have any idea?

I would like to understand more about this. Is this with newer/older
BIOS, or another hardware revision of the product, or something else?

Lyude, do you still have access to the unit you originally developed
the original change for? Is the behavior broken there as well?

Thanks.

-- 
Dmitry

Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"

[Lyude Paul]

On Tue, 2023-08-08 at 15:06 -0700, Dmitry Torokhov wrote:
> On Tue, Aug 08, 2023 at 05:49:23PM -0400, Lyude Paul wrote:
> > Hm, This looks fine to me (if not as a final fix, certainly as a workaround)
> > 
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> > 
> > However, this is definitely something we probably should try to fix at some
> > point - as I imagine this must be happening because something regarding how
> > clicks are reported must have changed again. Andrew, do you have any idea?
> 
> I would like to understand more about this. Is this with newer/older
> BIOS, or another hardware revision of the product, or something else?


oops, somehow when typing that response I totally forgot I was responding to a
revert ._., which changes everything

so yes - we should definitely look into this a bit more, I still have access
to this machine so I'll try to take a look tomorrow and see what's up
> 
> Lyude, do you still have access to the unit you originally developed
> the original change for? Is the behavior broken there as well?
> 
> Thanks.
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat

Re: [PATCH] Revert "Input: synaptics - enable InterTouch for the ThinkPad P1 G3"

[Sebastian Wick]

On Tue, Aug 08, 2023 at 03:06:32PM -0700, Dmitry Torokhov wrote:
> On Tue, Aug 08, 2023 at 05:49:23PM -0400, Lyude Paul wrote:
> > Hm, This looks fine to me (if not as a final fix, certainly as a workaround)
> > 
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> > 
> > However, this is definitely something we probably should try to fix at some
> > point - as I imagine this must be happening because something regarding how
> > clicks are reported must have changed again. Andrew, do you have any idea?
> 
> I would like to understand more about this. Is this with newer/older
> BIOS, or another hardware revision of the product, or something else?

All I can say is that the touchpad worked fine before and at some point
it stopped working. I remember updating the system and some firmware
components shortly before this happened but I don't know anymore what
those updates contained.

> Lyude, do you still have access to the unit you originally developed
> the original change for? Is the behavior broken there as well?
> 
> Thanks.
> 
> -- 
> Dmitry
>