From: Rahul Rameshbabu <sergeantsagara@protonmail.com>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Rahul Rameshbabu <sergeantsagara@protonmail.com>,
Rain <rain@sunshowers.io>
Subject: [PATCH] HID: multitouch: Add required quirk for Synaptics 0xcd7e device
Date: Sun, 17 Sep 2023 16:18:43 +0000 [thread overview]
Message-ID: <20230917161802.39716-1-sergeantsagara@protonmail.com> (raw)
Register the Synaptics device as a special multitouch device with certain
quirks that may improve usability of the touchpad device.
Reported-by: Rain <rain@sunshowers.io>
Closes: https://lore.kernel.org/linux-input/2bbb8e1d-1793-4df1-810f-cb0137341ff4@app.fastmail.com/
Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>
---
Notes:
Theory:
I think the Synaptics device in the related email to the linux-input
mailing list requires certain quirks like MT_QUIRK_HOVERING to correctly
reconfigure the distance configuration for multitouch events. This might
explain why light touches were not registered originally when
MT_CLS_DEFAULT was used by default for the device. Would like to have
this patch tested before being merged. A Tested-by: git trailer can then
be appended.
drivers/hid/hid-multitouch.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 521b2ffb4244..8db4ae05febc 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -2144,6 +2144,10 @@ static const struct hid_device_id mt_devices[] = {
USB_DEVICE_ID_MTP_STM)},
/* Synaptics devices */
+ { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
+ HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
+ USB_VENDOR_ID_SYNAPTICS, 0xcd7e) },
+
{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
USB_VENDOR_ID_SYNAPTICS, 0xce08) },
--
2.40.1
next reply other threads:[~2023-09-17 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 16:18 Rahul Rameshbabu [this message]
2023-10-04 18:54 ` [PATCH] HID: multitouch: Add required quirk for Synaptics 0xcd7e device Jiri Kosina
2023-10-04 19:01 ` Rain
2023-10-05 2:29 ` Rahul Rameshbabu
2023-10-05 2:33 ` Rain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230917161802.39716-1-sergeantsagara@protonmail.com \
--to=sergeantsagara@protonmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rain@sunshowers.io \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox