Linux Input/HID development
 help / color / mirror / Atom feed
From: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Joe Hung <joe_hung@ilitek.com>
Subject: [PATCH v2 2/2] Input: ilitek_ts_i2c - add report id message validation
Date: Wed, 20 Sep 2023 09:46:50 +0200	[thread overview]
Message-ID: <20230920074650.922292-3-ghidoliemanuele@gmail.com> (raw)
In-Reply-To: <20230920074650.922292-1-ghidoliemanuele@gmail.com>

From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

Ilitek touch IC driver answer to plain i2c read request, after it has
generated an interrupt request, with a report id message starting
with an identifier and a series of points.
If a request is sent unsolicited by an interrupt request the answer
do not contain this identifier.
Add a test to discard these messages, making the driver robust to
spurious interrupt requests.

Fixes: 42370681bd46 ("Input: Add support for ILITEK Lego Series")
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
---
 drivers/input/touchscreen/ilitek_ts_i2c.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c
index 0c3491e346f4..efce545236cd 100644
--- a/drivers/input/touchscreen/ilitek_ts_i2c.c
+++ b/drivers/input/touchscreen/ilitek_ts_i2c.c
@@ -37,6 +37,8 @@
 #define ILITEK_TP_CMD_GET_MCU_VER			0x61
 #define ILITEK_TP_CMD_GET_IC_MODE			0xC0
 
+#define ILITEK_TP_I2C_REPORT_ID				0x48
+
 #define REPORT_COUNT_ADDRESS				61
 #define ILITEK_SUPPORT_MAX_POINT			40
 
@@ -163,6 +165,11 @@ static int ilitek_process_and_report_v6(struct ilitek_ts_data *ts)
 		goto err_sync_frame;
 	}
 
+	if (buf[0] != ILITEK_TP_I2C_REPORT_ID) {
+		dev_err(dev, "get touch info failed. Wrong id: 0x%02X\n", buf[0]);
+		goto err_sync_frame;
+	}
+
 	report_max_point = buf[REPORT_COUNT_ADDRESS];
 	if (report_max_point > ts->max_tp) {
 		dev_err(dev, "FW report max point:%d > panel info. max:%d\n",
-- 
2.34.1


  parent reply	other threads:[~2023-09-20  7:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  7:46 [PATCH v2 0/2] Input: ilitek_ts_i2c - Fix spurious input events Emanuele Ghidoli
2023-09-20  7:46 ` [PATCH v2 1/2] Input: ilitek_ts_i2c - avoid wrong input subsystem sync Emanuele Ghidoli
2023-09-26  8:15   ` Francesco Dolcini
2023-09-20  7:46 ` Emanuele Ghidoli [this message]
2023-09-26  8:14   ` [PATCH v2 2/2] Input: ilitek_ts_i2c - add report id message validation Francesco Dolcini
2023-09-20  7:54 ` [PATCH v2 0/2] Input: ilitek_ts_i2c - Fix spurious input events Emanuele Ghidoli
2023-10-22 15:13 ` Francesco Dolcini
2023-11-21 14:00   ` Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230920074650.922292-3-ghidoliemanuele@gmail.com \
    --to=ghidoliemanuele@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=joe_hung@ilitek.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox