From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
<patches@opensource.cirrus.com>, <linux-input@vger.kernel.org>,
<kernel@pengutronix.de>
Subject: Re: [PATCH 52/52] input: wm97xx-core - Convert to platform remove callback returning void
Date: Wed, 20 Sep 2023 14:24:36 +0000 [thread overview]
Message-ID: <20230920142436.GJ103419@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20230920125829.1478827-53-u.kleine-koenig@pengutronix.de>
On Wed, Sep 20, 2023 at 02:58:29PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2023-09-20 14:24 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 12:57 [PATCH 00/52] input: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 01/52] input: adp5520-keys - " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 02/52] input: cros_ec_keyb " Uwe Kleine-König
2023-09-21 3:21 ` Tzung-Bi Shih
2023-09-20 12:57 ` [PATCH 03/52] input: ep93xx_keypad " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 04/52] input: iqs62x-keys " Uwe Kleine-König
2023-09-21 11:29 ` Jeff LaBundy
2023-09-20 12:57 ` [PATCH 05/52] input: matrix_keypad " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 06/52] input: omap-keypad " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 07/52] input: omap4-keypad " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 08/52] input: samsung-keypad " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 09/52] input: sh_keysc " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 10/52] input: spear-keyboard " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 11/52] input: stmpe-keypad " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 12/52] input: 88pm80x_onkey " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 13/52] input: da9052_onkey " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 14/52] input: da9055_onkey " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 15/52] input: ideapad_slidebar " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 16/52] input: m68kspkr " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 17/52] input: max8997_haptic " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 18/52] input: mc13783-pwrbutton " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 19/52] input: palmas-pwrbutton " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 20/52] input: pcap_keys " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 21/52] input: pcf50633-input " Uwe Kleine-König
2023-09-20 12:57 ` [PATCH 22/52] input: pcspkr " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 23/52] input: pm8941-pwrkey " Uwe Kleine-König
2023-09-20 13:03 ` Konrad Dybcio
2023-09-20 12:58 ` [PATCH 24/52] input: soc_button_array " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 25/52] input: sparcspkr " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 26/52] input: wistron_btns " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 27/52] input: wm831x-on " Uwe Kleine-König
2023-09-20 14:24 ` Charles Keepax
2023-09-20 12:58 ` [PATCH 28/52] input: navpoint " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 29/52] input: altera_ps2 " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 30/52] input: ams_delta_serio " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 31/52] input: apbps2 " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 32/52] input: arc_ps2 " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 33/52] input: ct82c710 " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 34/52] drivers/input/serio/i8042-sparcio.h :: " Uwe Kleine-König
2023-09-20 13:06 ` Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 35/52] input: i8042 - " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 36/52] input: ioc3kbd " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 37/52] input: maceps2 " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 38/52] input: olpc_apsp " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 39/52] input: ps2-gpio " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 40/52] input: q40kbd " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 41/52] input: rpckbd " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 42/52] input: sun4i-ps2 " Uwe Kleine-König
2023-09-20 16:07 ` Jernej Škrabec
2023-09-20 12:58 ` [PATCH 43/52] input: xilinx_ps2 " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 44/52] input: da9052_tsi " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 45/52] input: mainstone-wm97xx " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 46/52] input: mc13783_ts " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 47/52] input: pcap_ts " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 48/52] input: stmpe-ts " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 49/52] input: sun4i-ts " Uwe Kleine-König
2023-09-20 16:07 ` Jernej Škrabec
2023-09-20 12:58 ` [PATCH 50/52] input: ti_am335x_tsc " Uwe Kleine-König
2023-09-20 12:58 ` [PATCH 51/52] input: wm831x-ts " Uwe Kleine-König
2023-09-20 14:24 ` Charles Keepax
2023-09-20 12:58 ` [PATCH 52/52] input: wm97xx-core " Uwe Kleine-König
2023-09-20 14:24 ` Charles Keepax [this message]
2023-09-24 2:48 ` [PATCH 00/52] input: " Dmitry Torokhov
2023-09-24 15:50 ` Uwe Kleine-König
2023-09-30 15:37 ` Dmitry Torokhov
2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920142436.GJ103419@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).