From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-input-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CCF12E7D0AB
	for <linux-input@archiver.kernel.org>; Thu, 21 Sep 2023 21:00:37 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231916AbjIUVAm (ORCPT <rfc822;linux-input@archiver.kernel.org>);
        Thu, 21 Sep 2023 17:00:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35842 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231983AbjIUU75 (ORCPT
        <rfc822;linux-input@vger.kernel.org>);
        Thu, 21 Sep 2023 16:59:57 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 830F086807;
        Thu, 21 Sep 2023 10:38:00 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 384D9C4E753;
        Thu, 21 Sep 2023 15:29:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1695310162;
        bh=YRubwqeTifeA4hxGDHOuj3A8llGfWe15Yg+vIKGo/KQ=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=ghtZJW51nFyAJbX8IGGmWPHaVMTGDhpshg6uJhfm7ecaKMeYV7ZmNy3VqvcLpSBb0
         GlAoeOI+Xx17lJtCZt+tfA1ZzftsqVr8begb0yUvT19DqS2WOg04Uy4i+zYBjhbQjG
         oVni6z/QpNlEIwEcSWtbdc/ninRqMKbgaePXgOqjMITBM8uekywf/IDe2QVxY98LmZ
         pKkF4CTrIntIUYEvNgdeHO+1yhwGM/Mi4spQIHyQYhipOCmNmnOgeEKrQxaKHd1oVg
         BPDMkeqVNMaNgvjbjZBPxHYC1f8tUMy0ZPesZrNH1ifVfWJceeVcgathtCddib6kxv
         8OMM2htV20Pog==
Received: (nullmailer pid 378728 invoked by uid 1000);
        Thu, 21 Sep 2023 15:29:21 -0000
Date:   Thu, 21 Sep 2023 10:29:21 -0500
From:   Rob Herring <robh@kernel.org>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: input: gpio-keys: Allow optional
 dedicated wakeirq
Message-ID: <20230921152921.GA160147-robh@kernel.org>
References: <20230920115044.53098-1-tony@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230920115044.53098-1-tony@atomide.com>
Precedence: bulk
List-ID: <linux-input.vger.kernel.org>
X-Mailing-List: linux-input@vger.kernel.org

On Wed, Sep 20, 2023 at 02:50:43PM +0300, Tony Lindgren wrote:
> Allow configuring an optional dedicated wakeirq for gpio-keys that
> some SoCs have.
> 
> Let's use the common interrupt naming "irq" and "wakeup" that we already
> have in use for some drivers and subsystems like i2c framework.
> 
> Note that the gpio-keys interrupt property is optional. If only a gpio
> property is specified, the driver tries to translate the gpio into an
> interrupt.
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> 
> Changes since v1:
> 
> - Run make dt_binding_check on the binding
> 
> - Add better checks for interrupt-names as suggested by Rob, it is
>   now required if two interrupts are configured
> 
> - Add more decription entries
> 
> - Add a new example for key-wakeup
> 
> ---
>  .../devicetree/bindings/input/gpio-keys.yaml  | 41 ++++++++++++++++++-
>  1 file changed, 40 insertions(+), 1 deletion(-)

With the indentation fixed,

Reviewed-by: Rob Herring <robh@kernel.org>