* [PATCH 01/49] iio: accel: hid-sensor-accel-3d: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
@ 2023-09-19 17:48 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 34/49] iio: gyro: hid-sensor-gyro-3d: " Uwe Kleine-König
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:48 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/accel/hid-sensor-accel-3d.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index 5eac7ea19993..9b7a73a4c48a 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -422,7 +422,7 @@ static int hid_accel_3d_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_accel_3d_remove(struct platform_device *pdev)
+static void hid_accel_3d_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -431,8 +431,6 @@ static int hid_accel_3d_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, hsdev->usage);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &accel_state->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_accel_3d_ids[] = {
@@ -454,7 +452,7 @@ static struct platform_driver hid_accel_3d_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_accel_3d_probe,
- .remove = hid_accel_3d_remove,
+ .remove_new = hid_accel_3d_remove,
};
module_platform_driver(hid_accel_3d_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 34/49] iio: gyro: hid-sensor-gyro-3d: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 01/49] iio: accel: hid-sensor-accel-3d: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 35/49] iio: humidity: hid-sensor-humidity: " Uwe Kleine-König
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/gyro/hid-sensor-gyro-3d.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c
index 698c50da1f10..59a38bf9459b 100644
--- a/drivers/iio/gyro/hid-sensor-gyro-3d.c
+++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c
@@ -359,7 +359,7 @@ static int hid_gyro_3d_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_gyro_3d_remove(struct platform_device *pdev)
+static void hid_gyro_3d_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -368,8 +368,6 @@ static int hid_gyro_3d_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_GYRO_3D);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &gyro_state->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_gyro_3d_ids[] = {
@@ -388,7 +386,7 @@ static struct platform_driver hid_gyro_3d_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_gyro_3d_probe,
- .remove = hid_gyro_3d_remove,
+ .remove_new = hid_gyro_3d_remove,
};
module_platform_driver(hid_gyro_3d_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 35/49] iio: humidity: hid-sensor-humidity: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
2023-09-19 17:48 ` [PATCH 01/49] iio: accel: hid-sensor-accel-3d: " Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 34/49] iio: gyro: hid-sensor-gyro-3d: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 37/49] iio: light: hid-sensor-als: " Uwe Kleine-König
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/humidity/hid-sensor-humidity.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/humidity/hid-sensor-humidity.c b/drivers/iio/humidity/hid-sensor-humidity.c
index fa0fe404a70a..bf6d2636a85e 100644
--- a/drivers/iio/humidity/hid-sensor-humidity.c
+++ b/drivers/iio/humidity/hid-sensor-humidity.c
@@ -260,7 +260,7 @@ static int hid_humidity_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_humidity_remove(struct platform_device *pdev)
+static void hid_humidity_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev);
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -269,8 +269,6 @@ static int hid_humidity_remove(struct platform_device *pdev)
iio_device_unregister(indio_dev);
sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_HUMIDITY);
hid_sensor_remove_trigger(indio_dev, &humid_st->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_humidity_ids[] = {
@@ -289,7 +287,7 @@ static struct platform_driver hid_humidity_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_humidity_probe,
- .remove = hid_humidity_remove,
+ .remove_new = hid_humidity_remove,
};
module_platform_driver(hid_humidity_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 37/49] iio: light: hid-sensor-als: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (2 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 35/49] iio: humidity: hid-sensor-humidity: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 38/49] iio: light: hid-sensor-prox: " Uwe Kleine-König
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/light/hid-sensor-als.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
index eb1aedad7edc..cb76841ec0ce 100644
--- a/drivers/iio/light/hid-sensor-als.c
+++ b/drivers/iio/light/hid-sensor-als.c
@@ -347,7 +347,7 @@ static int hid_als_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_als_remove(struct platform_device *pdev)
+static void hid_als_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -356,8 +356,6 @@ static int hid_als_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, hsdev->usage);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &als_state->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_als_ids[] = {
@@ -380,7 +378,7 @@ static struct platform_driver hid_als_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_als_probe,
- .remove = hid_als_remove,
+ .remove_new = hid_als_remove,
};
module_platform_driver(hid_als_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 38/49] iio: light: hid-sensor-prox: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (3 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 37/49] iio: light: hid-sensor-als: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 40/49] iio: magnetometer: hid-sensor-magn-3d: " Uwe Kleine-König
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/light/hid-sensor-prox.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index a47591e1bad9..26c481d2998c 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -313,7 +313,7 @@ static int hid_prox_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_prox_remove(struct platform_device *pdev)
+static void hid_prox_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -322,8 +322,6 @@ static int hid_prox_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, hsdev->usage);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &prox_state->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_prox_ids[] = {
@@ -346,7 +344,7 @@ static struct platform_driver hid_prox_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_prox_probe,
- .remove = hid_prox_remove,
+ .remove_new = hid_prox_remove,
};
module_platform_driver(hid_prox_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 40/49] iio: magnetometer: hid-sensor-magn-3d: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (4 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 38/49] iio: light: hid-sensor-prox: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 41/49] iio: orientation: hid-sensor-incl-3d: " Uwe Kleine-König
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index e85a3a8eea90..5c795a430d09 100644
--- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
+++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
@@ -547,7 +547,7 @@ static int hid_magn_3d_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_magn_3d_remove(struct platform_device *pdev)
+static void hid_magn_3d_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -556,8 +556,6 @@ static int hid_magn_3d_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_COMPASS_3D);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &magn_state->magn_flux_attributes);
-
- return 0;
}
static const struct platform_device_id hid_magn_3d_ids[] = {
@@ -576,7 +574,7 @@ static struct platform_driver hid_magn_3d_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_magn_3d_probe,
- .remove = hid_magn_3d_remove,
+ .remove_new = hid_magn_3d_remove,
};
module_platform_driver(hid_magn_3d_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 41/49] iio: orientation: hid-sensor-incl-3d: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (5 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 40/49] iio: magnetometer: hid-sensor-magn-3d: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 42/49] iio: orientation: hid-sensor-rotation: " Uwe Kleine-König
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/orientation/hid-sensor-incl-3d.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/orientation/hid-sensor-incl-3d.c b/drivers/iio/orientation/hid-sensor-incl-3d.c
index ba5b581d5b25..8943d5c78bc0 100644
--- a/drivers/iio/orientation/hid-sensor-incl-3d.c
+++ b/drivers/iio/orientation/hid-sensor-incl-3d.c
@@ -383,7 +383,7 @@ static int hid_incl_3d_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_incl_3d_remove(struct platform_device *pdev)
+static void hid_incl_3d_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -392,8 +392,6 @@ static int hid_incl_3d_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_INCLINOMETER_3D);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &incl_state->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_incl_3d_ids[] = {
@@ -412,7 +410,7 @@ static struct platform_driver hid_incl_3d_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_incl_3d_probe,
- .remove = hid_incl_3d_remove,
+ .remove_new = hid_incl_3d_remove,
};
module_platform_driver(hid_incl_3d_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 42/49] iio: orientation: hid-sensor-rotation: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (6 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 41/49] iio: orientation: hid-sensor-incl-3d: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 43/49] iio: position: hid-sensor-custom-intel-hinge: " Uwe Kleine-König
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/orientation/hid-sensor-rotation.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c
index a033699910e8..5e8cadd5177a 100644
--- a/drivers/iio/orientation/hid-sensor-rotation.c
+++ b/drivers/iio/orientation/hid-sensor-rotation.c
@@ -327,7 +327,7 @@ static int hid_dev_rot_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_dev_rot_remove(struct platform_device *pdev)
+static void hid_dev_rot_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -336,8 +336,6 @@ static int hid_dev_rot_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, hsdev->usage);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &rot_state->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_dev_rot_ids[] = {
@@ -364,7 +362,7 @@ static struct platform_driver hid_dev_rot_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_dev_rot_probe,
- .remove = hid_dev_rot_remove,
+ .remove_new = hid_dev_rot_remove,
};
module_platform_driver(hid_dev_rot_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 43/49] iio: position: hid-sensor-custom-intel-hinge: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (7 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 42/49] iio: orientation: hid-sensor-rotation: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 44/49] iio: pressure: hid-sensor: " Uwe Kleine-König
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/position/hid-sensor-custom-intel-hinge.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/position/hid-sensor-custom-intel-hinge.c b/drivers/iio/position/hid-sensor-custom-intel-hinge.c
index 07c30d217255..76e173850a35 100644
--- a/drivers/iio/position/hid-sensor-custom-intel-hinge.c
+++ b/drivers/iio/position/hid-sensor-custom-intel-hinge.c
@@ -342,7 +342,7 @@ static int hid_hinge_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_hinge_remove(struct platform_device *pdev)
+static void hid_hinge_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -351,8 +351,6 @@ static int hid_hinge_remove(struct platform_device *pdev)
iio_device_unregister(indio_dev);
sensor_hub_remove_callback(hsdev, hsdev->usage);
hid_sensor_remove_trigger(indio_dev, &st->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_hinge_ids[] = {
@@ -371,7 +369,7 @@ static struct platform_driver hid_hinge_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_hinge_probe,
- .remove = hid_hinge_remove,
+ .remove_new = hid_hinge_remove,
};
module_platform_driver(hid_hinge_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 44/49] iio: pressure: hid-sensor: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (8 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 43/49] iio: position: hid-sensor-custom-intel-hinge: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-19 17:49 ` [PATCH 47/49] iio: temperature: " Uwe Kleine-König
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/pressure/hid-sensor-press.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/pressure/hid-sensor-press.c b/drivers/iio/pressure/hid-sensor-press.c
index a9215eb32d70..956045e2db29 100644
--- a/drivers/iio/pressure/hid-sensor-press.c
+++ b/drivers/iio/pressure/hid-sensor-press.c
@@ -323,7 +323,7 @@ static int hid_press_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_press_remove(struct platform_device *pdev)
+static void hid_press_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = pdev->dev.platform_data;
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -332,8 +332,6 @@ static int hid_press_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_PRESSURE);
iio_device_unregister(indio_dev);
hid_sensor_remove_trigger(indio_dev, &press_state->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_press_ids[] = {
@@ -352,7 +350,7 @@ static struct platform_driver hid_press_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_press_probe,
- .remove = hid_press_remove,
+ .remove_new = hid_press_remove,
};
module_platform_driver(hid_press_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 47/49] iio: temperature: hid-sensor: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (9 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 44/49] iio: pressure: hid-sensor: " Uwe Kleine-König
@ 2023-09-19 17:49 ` Uwe Kleine-König
2023-09-23 17:35 ` [PATCH 00/49] iio: " Jonathan Cameron
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Uwe Kleine-König @ 2023-09-19 17:49 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/iio/temperature/hid-sensor-temperature.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/temperature/hid-sensor-temperature.c b/drivers/iio/temperature/hid-sensor-temperature.c
index d40f235af1d4..0143fd478933 100644
--- a/drivers/iio/temperature/hid-sensor-temperature.c
+++ b/drivers/iio/temperature/hid-sensor-temperature.c
@@ -257,7 +257,7 @@ static int hid_temperature_probe(struct platform_device *pdev)
}
/* Function to deinitialize the processing for usage id */
-static int hid_temperature_remove(struct platform_device *pdev)
+static void hid_temperature_remove(struct platform_device *pdev)
{
struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev);
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -265,8 +265,6 @@ static int hid_temperature_remove(struct platform_device *pdev)
sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TEMPERATURE);
hid_sensor_remove_trigger(indio_dev, &temp_st->common_attributes);
-
- return 0;
}
static const struct platform_device_id hid_temperature_ids[] = {
@@ -285,7 +283,7 @@ static struct platform_driver hid_temperature_platform_driver = {
.pm = &hid_sensor_pm_ops,
},
.probe = hid_temperature_probe,
- .remove = hid_temperature_remove,
+ .remove_new = hid_temperature_remove,
};
module_platform_driver(hid_temperature_platform_driver);
--
2.40.1
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH 00/49] iio: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (10 preceding siblings ...)
2023-09-19 17:49 ` [PATCH 47/49] iio: temperature: " Uwe Kleine-König
@ 2023-09-23 17:35 ` Jonathan Cameron
2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
13 siblings, 0 replies; 15+ messages in thread
From: Jonathan Cameron @ 2023-09-23 17:35 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Jiri Kosina, Srinivas Pandruvada, Lars-Peter Clausen, linux-input,
linux-iio, kernel, Linus Walleij, linux-arm-kernel, Eugen Hristev,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Jinjie Ruan,
Rob Herring, Heiko Stuebner, Yang Yingliang, Chen-Yu Tsai,
Aidan MacDonald, Andy Shevchenko, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Hartley Sweeten,
Alexander Sverdlin, Krzysztof Kozlowski, Alim Akhtar,
linux-samsung-soc, Shawn Guo, Sascha Hauer, Fabio Estevam,
NXP Linux Team, Andreas Klinger, Cai Huoqing, Haibo Chen,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
George Stark, Andy Shevchenko, Nuno Sá, linux-amlogic,
Saravanan Sekar, Jiakai Luo, Dongliang Mu, Avi Fishman,
Tomer Maimon, Tali Perry, Patrick Venture, Nancy Yuen,
Benjamin Fair, openbmc, Andy Gross, Bjorn Andersson,
Konrad Dybcio, linux-arm-msm, Marek Vasut, Maxime Coquelin,
Alexandre Torgue, Olivier Moysan, Fabrice Gasnier, Zhang Shurong,
Yangtao Li, linux-stm32, Sean Nyekjaer, Tom Rix, Jernej Skrabec,
Samuel Holland, Rafael J. Wysocki, Damien Le Moal, Mark Brown,
Ido Schimmel, Daniel Lezcano, linux-sunxi, Dmitry Torokhov,
Andreas Kemnade, Peter Rosin, Vladimir Zapolskiy, Kevin Tsai,
Benson Leung, Guenter Roeck, chrome-platform
On Tue, 19 Sep 2023 19:48:42 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> this series converts all platform drivers below drivers/iio to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side. As all platform drivers return zero unconditionally in their
> remove callback up to now, the conversions are "trivial".
>
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
> There are no interdependencies between the patches. As there are still
> quite a few drivers to convert, I'm happy about every patch that makes
> it in. So even if there is a merge conflict with one patch until you
> apply or I picked a wrong subject prefix, please apply the remainder of
> this series anyhow.
>
Series applied to the togreg branch of iio.git and pushed out as testing
to see if 0-day finds anything we are missing.
I've picked up all tags give as of early today.
Thanks,
Jonathan
> Best regards
> Uwe
>
> Uwe Kleine-König (49):
> iio: accel: hid-sensor-accel-3d: Convert to platform remove callback
> returning void
> iio: adc: ab8500-gpadc: Convert to platform remove callback returning
> void
> iio: adc: at91-sama5d2: Convert to platform remove callback returning
> void
> iio: adc: at91: Convert to platform remove callback returning void
> iio: adc: axp20x: Convert to platform remove callback returning void
> iio: adc: bcm_iproc: Convert to platform remove callback returning
> void
> iio: adc: dln2: Convert to platform remove callback returning void
> iio: adc: ep93xx: Convert to platform remove callback returning void
> iio: adc: exynos: Convert to platform remove callback returning void
> iio: adc: fsl-imx25-gcq: Convert to platform remove callback returning
> void
> iio: adc: hx711: Convert to platform remove callback returning void
> iio: adc: imx8qxp: Convert to platform remove callback returning void
> iio: adc: imx93: Convert to platform remove callback returning void
> iio: adc: meson_saradc: Convert to platform remove callback returning
> void
> iio: adc: mp2629: Convert to platform remove callback returning void
> iio: adc: mxs-lradc: Convert to platform remove callback returning
> void
> iio: adc: npcm: Convert to platform remove callback returning void
> iio: adc: qcom-pm8xxx-xoadc: Convert to platform remove callback
> returning void
> iio: adc: rcar-gyroadc: Convert to platform remove callback returning
> void
> iio: adc: stm32-adc-core: Convert to platform remove callback
> returning void
> iio: adc: stm32-adc: Convert to platform remove callback returning
> void
> iio: adc: stm32-dfsdm-adc: Convert to platform remove callback
> returning void
> iio: adc: stm32-dfsdm-core: Convert to platform remove callback
> returning void
> iio: adc: sun4i-gpadc-iio: Convert to platform remove callback
> returning void
> iio: adc: ti_am335x_adc: Convert to platform remove callback returning
> void
> iio: adc: twl4030-madc: Convert to platform remove callback returning
> void
> iio: adc: twl6030-gpadc: Convert to platform remove callback returning
> void
> iio: adc: vf610_adc: Convert to platform remove callback returning
> void
> iio: dac: dpot-dac: Convert to platform remove callback returning void
> iio: dac: lpc18xx_dac: Convert to platform remove callback returning
> void
> iio: dac: stm32-dac-core: Convert to platform remove callback
> returning void
> iio: dac: stm32-dac: Convert to platform remove callback returning
> void
> iio: dac: vf610: Convert to platform remove callback returning void
> iio: gyro: hid-sensor-gyro-3d: Convert to platform remove callback
> returning void
> iio: humidity: hid-sensor-humidity: Convert to platform remove
> callback returning void
> iio: light: cm3605: Convert to platform remove callback returning void
> iio: light: hid-sensor-als: Convert to platform remove callback
> returning void
> iio: light: hid-sensor-prox: Convert to platform remove callback
> returning void
> iio: light: lm3533-als: Convert to platform remove callback returning
> void
> iio: magnetometer: hid-sensor-magn-3d: Convert to platform remove
> callback returning void
> iio: orientation: hid-sensor-incl-3d: Convert to platform remove
> callback returning void
> iio: orientation: hid-sensor-rotation: Convert to platform remove
> callback returning void
> iio: position: hid-sensor-custom-intel-hinge: Convert to platform
> remove callback returning void
> iio: pressure: hid-sensor: Convert to platform remove callback
> returning void
> iio: proximity: cros_ec_mkbp: Convert to platform remove callback
> returning void
> iio: proximity: srf04: Convert to platform remove callback returning
> void
> iio: temperature: hid-sensor: Convert to platform remove callback
> returning void
> iio: trigger: iio-trig-interrupt: Convert to platform remove callback
> returning void
> iio: trigger: stm32-timer: Convert to platform remove callback
> returning void
>
> drivers/iio/accel/hid-sensor-accel-3d.c | 6 ++----
> drivers/iio/adc/ab8500-gpadc.c | 6 ++----
> drivers/iio/adc/at91-sama5d2_adc.c | 6 ++----
> drivers/iio/adc/at91_adc.c | 6 ++----
> drivers/iio/adc/axp20x_adc.c | 6 ++----
> drivers/iio/adc/bcm_iproc_adc.c | 6 ++----
> drivers/iio/adc/dln2-adc.c | 5 ++---
> drivers/iio/adc/ep93xx_adc.c | 6 ++----
> drivers/iio/adc/exynos_adc.c | 6 ++----
> drivers/iio/adc/fsl-imx25-gcq.c | 6 ++----
> drivers/iio/adc/hx711.c | 6 ++----
> drivers/iio/adc/imx8qxp-adc.c | 6 ++----
> drivers/iio/adc/imx93_adc.c | 6 ++----
> drivers/iio/adc/meson_saradc.c | 6 ++----
> drivers/iio/adc/mp2629_adc.c | 6 ++----
> drivers/iio/adc/mxs-lradc-adc.c | 6 ++----
> drivers/iio/adc/npcm_adc.c | 6 ++----
> drivers/iio/adc/qcom-pm8xxx-xoadc.c | 6 ++----
> drivers/iio/adc/rcar-gyroadc.c | 6 ++----
> drivers/iio/adc/stm32-adc-core.c | 6 ++----
> drivers/iio/adc/stm32-adc.c | 6 ++----
> drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++----
> drivers/iio/adc/stm32-dfsdm-core.c | 6 ++----
> drivers/iio/adc/sun4i-gpadc-iio.c | 8 +++-----
> drivers/iio/adc/ti_am335x_adc.c | 6 ++----
> drivers/iio/adc/twl4030-madc.c | 6 ++----
> drivers/iio/adc/twl6030-gpadc.c | 6 ++----
> drivers/iio/adc/vf610_adc.c | 6 ++----
> drivers/iio/dac/dpot-dac.c | 6 ++----
> drivers/iio/dac/lpc18xx_dac.c | 6 ++----
> drivers/iio/dac/stm32-dac-core.c | 6 ++----
> drivers/iio/dac/stm32-dac.c | 6 ++----
> drivers/iio/dac/vf610_dac.c | 6 ++----
> drivers/iio/gyro/hid-sensor-gyro-3d.c | 6 ++----
> drivers/iio/humidity/hid-sensor-humidity.c | 6 ++----
> drivers/iio/light/cm3605.c | 6 ++----
> drivers/iio/light/hid-sensor-als.c | 6 ++----
> drivers/iio/light/hid-sensor-prox.c | 6 ++----
> drivers/iio/light/lm3533-als.c | 6 ++----
> drivers/iio/magnetometer/hid-sensor-magn-3d.c | 6 ++----
> drivers/iio/orientation/hid-sensor-incl-3d.c | 6 ++----
> drivers/iio/orientation/hid-sensor-rotation.c | 6 ++----
> drivers/iio/position/hid-sensor-custom-intel-hinge.c | 6 ++----
> drivers/iio/pressure/hid-sensor-press.c | 6 ++----
> drivers/iio/proximity/cros_ec_mkbp_proximity.c | 6 ++----
> drivers/iio/proximity/srf04.c | 6 ++----
> drivers/iio/temperature/hid-sensor-temperature.c | 6 ++----
> drivers/iio/trigger/iio-trig-interrupt.c | 6 ++----
> drivers/iio/trigger/stm32-timer-trigger.c | 6 ++----
> 49 files changed, 99 insertions(+), 196 deletions(-)
>
>
> base-commit: 29e400e3ea486bf942b214769fc9778098114113
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 00/49] iio: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (11 preceding siblings ...)
2023-09-23 17:35 ` [PATCH 00/49] iio: " Jonathan Cameron
@ 2023-11-13 3:23 ` patchwork-bot+chrome-platform
2023-11-13 3:42 ` patchwork-bot+chrome-platform
13 siblings, 0 replies; 15+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-11-13 3:23 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: jic23, jikos, srinivas.pandruvada, lars, linux-input, linux-iio,
kernel, linus.walleij, linux-arm-kernel, eugen.hristev,
nicolas.ferre, alexandre.belloni, claudiu.beznea, ruanjinjie,
robh, heiko, yangyingliang, wens, aidanmacdonald.0x0,
andy.shevchenko, rjui, sbranden, bcm-kernel-feedback-list,
hsweeten, alexander.sverdlin, krzysztof.kozlowski, alim.akhtar,
linux-samsung-soc, shawnguo, s.hauer, festevam, linux-imx, ak,
cai.huoqing, haibo.chen, neil.armstrong, khilman, jbrunet,
martin.blumenstingl, gnstark, andriy.shevchenko, nuno.sa,
linux-amlogic, sravanhome, jkluo, dzm91, avifishman70, tmaimon77,
tali.perry1, venture, yuenn, benjaminfair, openbmc, agross,
andersson, konrad.dybcio, linux-arm-msm, marek.vasut,
mcoquelin.stm32, alexandre.torgue, olivier.moysan,
fabrice.gasnier, zhang_shurong, frank.li, linux-stm32, sean, trix,
jernej.skrabec, samuel, rafael.j.wysocki, damien.lemoal, broonie,
idosch, daniel.lezcano, linux-sunxi, dmitry.torokhov, andreas,
peda, vz, ktsai, bleung, groeck, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Jonathan Cameron <Jonathan.Cameron@huawei.com>:
On Tue, 19 Sep 2023 19:48:42 +0200 you wrote:
> this series converts all platform drivers below drivers/iio to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side. As all platform drivers return zero unconditionally in their
> remove callback up to now, the conversions are "trivial".
>
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
> [...]
Here is the summary with links:
- [45/49] iio: proximity: cros_ec_mkbp: Convert to platform remove callback returning void
https://git.kernel.org/chrome-platform/c/2df694f710d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 00/49] iio: Convert to platform remove callback returning void
2023-09-19 17:48 [PATCH 00/49] iio: Convert to platform remove callback returning void Uwe Kleine-König
` (12 preceding siblings ...)
2023-11-13 3:23 ` patchwork-bot+chrome-platform
@ 2023-11-13 3:42 ` patchwork-bot+chrome-platform
13 siblings, 0 replies; 15+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-11-13 3:42 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: jic23, jikos, srinivas.pandruvada, lars, linux-input, linux-iio,
kernel, linus.walleij, linux-arm-kernel, eugen.hristev,
nicolas.ferre, alexandre.belloni, claudiu.beznea, ruanjinjie,
robh, heiko, yangyingliang, wens, aidanmacdonald.0x0,
andy.shevchenko, rjui, sbranden, bcm-kernel-feedback-list,
hsweeten, alexander.sverdlin, krzysztof.kozlowski, alim.akhtar,
linux-samsung-soc, shawnguo, s.hauer, festevam, linux-imx, ak,
cai.huoqing, haibo.chen, neil.armstrong, khilman, jbrunet,
martin.blumenstingl, gnstark, andriy.shevchenko, nuno.sa,
linux-amlogic, sravanhome, jkluo, dzm91, avifishman70, tmaimon77,
tali.perry1, venture, yuenn, benjaminfair, openbmc, agross,
andersson, konrad.dybcio, linux-arm-msm, marek.vasut,
mcoquelin.stm32, alexandre.torgue, olivier.moysan,
fabrice.gasnier, zhang_shurong, frank.li, linux-stm32, sean, trix,
jernej.skrabec, samuel, rafael.j.wysocki, damien.lemoal, broonie,
idosch, daniel.lezcano, linux-sunxi, dmitry.torokhov, andreas,
peda, vz, ktsai, bleung, groeck, chrome-platform
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Jonathan Cameron <Jonathan.Cameron@huawei.com>:
On Tue, 19 Sep 2023 19:48:42 +0200 you wrote:
> this series converts all platform drivers below drivers/iio to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side. As all platform drivers return zero unconditionally in their
> remove callback up to now, the conversions are "trivial".
>
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
> [...]
Here is the summary with links:
- [45/49] iio: proximity: cros_ec_mkbp: Convert to platform remove callback returning void
https://git.kernel.org/chrome-platform/c/2df694f710d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 15+ messages in thread