From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeffery Miller <jefferymiller@google.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
regressions@lists.linux.dev, benjamin.tissoires@redhat.com,
linux@leemhuis.info, Andrew Duggan <aduggan@synaptics.com>,
Andrew Duggan <andrew@duggan.us>,
loic.poulain@linaro.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode
Date: Wed, 4 Oct 2023 08:19:33 +0200 [thread overview]
Message-ID: <2023100418-clapping-driven-bc09@gregkh> (raw)
In-Reply-To: <20231004005729.3943515-1-jefferymiller@google.com>
On Tue, Oct 03, 2023 at 07:57:24PM -0500, Jeffery Miller wrote:
> Make `elantech_setup_ps2` set a compatible fast_reconnect pointer
> when its ps2 mode is used.
>
> When an SMBus connection is attempted and fails `psmouse_smbus_init`
> sets fast_reconnect to `psmouse_smbus_reconnect`.
> `psmouse_smbus_reconnect` expects `psmouse->private` to be
> `struct psmouse_smbus_dev` but `elantech_setup_ps2` replaces
> it with its private data. This was causing an issue on resume
> since psmouse_smbus_reconnect was being called while in ps2, not SMBus
> mode.
>
> This was uncovered by commit 92e24e0e57f7 ("Input: psmouse - add delay when
> deactivating for SMBus mode")
>
> Closes:
> Link:https://lore.kernel.org/all/ca0109fa-c64b-43c1-a651-75b294d750a1@leemhuis.info/
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
>
> Signed-off-by: Jeffery Miller <jefferymiller@google.com>
> ---
>
> The other callbacks set in psmouse_smbus_init are already replaced.
> Should fast_reconnect be set to `elantech_reconnect` instead?
What commit id does this fix? Should it also have a cc: stable tag?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-04 6:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 0:57 [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode Jeffery Miller
2023-10-04 5:07 ` Thorsten Leemhuis
2023-10-04 6:19 ` Greg Kroah-Hartman [this message]
2023-10-04 6:34 ` Thorsten Leemhuis
2023-10-05 0:35 ` Jeffery Miller
2023-10-04 14:10 ` Dmitry Torokhov
2023-10-05 0:13 ` Jeffery Miller
2023-10-10 7:08 ` Thorsten Leemhuis
2023-10-12 22:53 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100418-clapping-driven-bc09@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aduggan@synaptics.com \
--cc=andrew@duggan.us \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jefferymiller@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=loic.poulain@linaro.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).