From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: dmitry.torokhov@gmail.com, Jonathan.Cameron@huawei.com,
robh@kernel.org, frank.li@vivo.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [RFC PATCH] Input: omap4-keypad: react on keypresses if device is runtime-suspended
Date: Wed, 11 Oct 2023 13:07:26 +0300 [thread overview]
Message-ID: <20231011100726.GD34982@atomide.com> (raw)
In-Reply-To: <20230929200046.2300333-1-andreas@kemnade.info>
Hi,
* Andreas Kemnade <andreas@kemnade.info> [230929 23:01]:
> According to SWPU235AB, table 26-6, fclk is required to generate events
> at least on OMAP4460, so keep fclk enabled all the time the device
> is opened.
Sorry for the delay, the patch looks good to me:
Reviewed-by: Tony Lindgren <tony@atomide.com>
> Open questions:
> - Should we rather (or also use) padconf irqs?
The keypad is in the wakeup domain and has SYSC_OMAP2_ENAWAKEUP set in
the dts, so padconf irqs should not be needed as long as the device is
clocked. As the source clock is sys_32k_ck, not sure if gating it would
save any power, so padconf interrupts are probably not needed.
> - It seems not to be required everywhere. Does it harm somewhere?
Sounds like on 4430 the gate bit does not do anything while on 4460 it
does. The source clock seems to be sys_32k_ck so it's enabled anyways
and should not affect power management.
Regards,
Tony
next prev parent reply other threads:[~2023-10-11 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 20:00 [RFC PATCH] Input: omap4-keypad: react on keypresses if device is runtime-suspended Andreas Kemnade
2023-10-11 10:07 ` Tony Lindgren [this message]
2023-10-11 15:45 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011100726.GD34982@atomide.com \
--to=tony@atomide.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andreas@kemnade.info \
--cc=dmitry.torokhov@gmail.com \
--cc=frank.li@vivo.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).