From: Andreas Kemnade <andreas@kemnade.info>
To: Stephen Boyd <sboyd@kernel.org>
Cc: bcousson@baylibre.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
linux-clk@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org, tony@atomide.com
Subject: Re: [PATCH v4 4/5] clk: twl: add clock driver for TWL6032
Date: Thu, 19 Oct 2023 09:18:35 +0200 [thread overview]
Message-ID: <20231019091835.6d8df469@akair> (raw)
In-Reply-To: <8c63372175266d42efbfca0104e19a14.sboyd@kernel.org>
Am Wed, 18 Oct 2023 18:20:22 -0700
schrieb Stephen Boyd <sboyd@kernel.org>:
> Quoting Andreas Kemnade (2023-09-16 03:05:14)
> > The TWL6032 has some clock outputs which are controlled like
> > fixed-voltage regulators, in some drivers for these chips
> > found in the wild, just the regulator api is abused for controlling
> > them, so simply use something similar to the regulator functions.
> > Due to a lack of hardware available for testing, leave out the
> > TWL6030-specific part of those functions.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
>
> Did you want me to pick this up in clk tree?
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
>
Well, Lee has picked up 1-3 of this series, so I think it is a good idea
if you take it. I do not think it will make things any easier if it goes
through Tony's tree because part 5 is a bit tricky.
If picked up independently (of the whole set and not only part 4), there
will be a range of commits were WLAN will not work at all instead of
basically working randomly by the clock is enabled for some reason (can
happen if warm-booted from the vendor kernel).
So IMHO for part 5 we have to decide wether to decide if above is
considered to break bisectability and take the patch for 6.8 or
ignore that and take it for 6.7.
But no matter how we decide, that should not affect the route for this
part 4. So it is a good idea to have it through the clk tree.
Regrads,
Andreas
next prev parent reply other threads:[~2023-10-19 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 10:05 [PATCH v4 0/5] ARM: omap: omap4-embt2ws: 32K clock for WLAN Andreas Kemnade
2023-09-16 10:05 ` [PATCH v4 1/5] dt-bindings: mfd: convert twl-family.txt to json-schema Andreas Kemnade
2023-09-16 10:05 ` [PATCH v4 2/5] dt-bindings: mfd: ti,twl: Add clock provider properties Andreas Kemnade
2023-10-19 1:22 ` Stephen Boyd
2023-09-16 10:05 ` [PATCH v4 3/5] mfd: twl-core: Add a clock subdevice for the TWL6032 Andreas Kemnade
2023-09-16 10:05 ` [PATCH v4 4/5] clk: twl: add clock driver for TWL6032 Andreas Kemnade
2023-10-13 6:08 ` Andreas Kemnade
2023-10-19 1:20 ` Stephen Boyd
2023-10-19 7:18 ` Andreas Kemnade [this message]
2023-10-19 23:43 ` Stephen Boyd
2023-09-16 10:05 ` [PATCH v4 5/5] ARM: dts: omap4-embt2ws: enable 32K clock on WLAN Andreas Kemnade
2023-10-07 6:53 ` Tony Lindgren
2023-11-30 12:03 ` Tony Lindgren
2023-09-20 13:45 ` (subset) [PATCH v4 0/5] ARM: omap: omap4-embt2ws: 32K clock for WLAN Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019091835.6d8df469@akair \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).