From: Lee Jones <lee@kernel.org>
To: Jeff LaBundy <jeff@labundy.com>
Cc: James Ogletree <james.ogletree@opensource.cirrus.com>,
James Ogletree <james.ogletree@cirrus.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Fred Treven <fred.treven@cirrus.com>,
Ben Bright <ben.bright@cirrus.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/4] mfd: cs40l50: Add support for CS40L50 core driver
Date: Wed, 25 Oct 2023 10:26:39 +0100 [thread overview]
Message-ID: <20231025092639.GL8909@google.com> (raw)
In-Reply-To: <ZTiJYxAvqfBMMJ1S@nixie71>
On Tue, 24 Oct 2023, Jeff LaBundy wrote:
> Hi James,
>
> Just a few trailing comments on top of Lee's feedback.
>
> On Wed, Oct 18, 2023 at 05:57:24PM +0000, James Ogletree wrote:
> > From: James Ogletree <james.ogletree@cirrus.com>
> >
> > Introduce support for Cirrus Logic Device CS40L50: a
> > haptic driver with waveform memory, integrated DSP,
> > and closed-loop algorithms.
> >
> > The MFD component registers and initializes the device.
> >
> > Signed-off-by: James Ogletree <james.ogletree@cirrus.com>
> > ---
> > MAINTAINERS | 2 +
> > drivers/mfd/Kconfig | 30 +++
> > drivers/mfd/Makefile | 4 +
> > drivers/mfd/cs40l50-core.c | 443 ++++++++++++++++++++++++++++++++++++
> > drivers/mfd/cs40l50-i2c.c | 69 ++++++
> > drivers/mfd/cs40l50-spi.c | 68 ++++++
> > include/linux/mfd/cs40l50.h | 198 ++++++++++++++++
> > 7 files changed, 814 insertions(+)
> > create mode 100644 drivers/mfd/cs40l50-core.c
> > create mode 100644 drivers/mfd/cs40l50-i2c.c
> > create mode 100644 drivers/mfd/cs40l50-spi.c
> > create mode 100644 include/linux/mfd/cs40l50.h
Just popping along to say; these are excellent comments Jeff.
Thank you for your review.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-10-25 9:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 17:57 [PATCH v4 0/4] Add support for CS40L50 James Ogletree
2023-10-18 17:57 ` [PATCH v4 1/4] dt-bindings: input: cirrus,cs40l50: Add initial DT binding James Ogletree
2023-10-18 19:21 ` Krzysztof Kozlowski
2023-10-18 21:44 ` James Ogletree
2023-10-18 17:57 ` [PATCH v4 2/4] Input: cs40l50 - Add cirrus haptics base support James Ogletree
2023-10-25 2:04 ` Jeff LaBundy
2023-11-01 20:46 ` James Ogletree
2023-11-26 0:52 ` Jeff LaBundy
2023-11-29 22:22 ` James Ogletree
2023-12-14 2:11 ` Jeff LaBundy
2023-10-18 17:57 ` [PATCH v4 3/4] mfd: cs40l50: Add support for CS40L50 core driver James Ogletree
2023-10-19 16:23 ` Lee Jones
2023-10-20 15:39 ` James Ogletree
2023-10-23 9:20 ` Lee Jones
2023-10-24 1:08 ` Jeff LaBundy
2023-10-24 1:30 ` James Ogletree
2023-10-24 15:47 ` Lee Jones
2023-10-24 1:14 ` James Ogletree
2023-10-21 14:56 ` kernel test robot
2023-10-25 3:20 ` Jeff LaBundy
2023-10-25 9:26 ` Lee Jones [this message]
[not found] ` <ZTiD5VUSi65OK4VK@nixie71>
2023-11-01 20:47 ` James Ogletree
2023-11-26 1:03 ` Jeff LaBundy
2023-10-18 17:57 ` [PATCH v4 4/4] Input: cs40l50 - Add support for the CS40L50 haptic driver James Ogletree
2023-10-20 15:30 ` kernel test robot
2023-10-25 3:03 ` Jeff LaBundy
2023-11-01 20:47 ` James Ogletree
2023-11-26 1:11 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025092639.GL8909@google.com \
--to=lee@kernel.org \
--cc=ben.bright@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fred.treven@cirrus.com \
--cc=james.ogletree@cirrus.com \
--cc=james.ogletree@opensource.cirrus.com \
--cc=jeff@labundy.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).