From: "Luke D. Jones" <luke@ljones.dev>
To: jikos@kernel.org
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, benato.denis96@gmail.com
Subject: [PATCH 0/2] hid-asus: reset the backlight brightness level on resume
Date: Fri, 17 Nov 2023 14:15:54 +1300 [thread overview]
Message-ID: <20231117011556.13067-1-luke@ljones.dev> (raw)
From: Denis Benato <benato.denis96@gmail.com>
I have noticed that in my Asus device RC71L the keyboard backlight is LEDs brightness of two RGB rings around two joysticks of this handheld device.
The firmware on this device (and other devices from the same manufacturer) restores a default brightness level (that is full brightness for my device and off for some others) after resuming from sleep; that means sysfs will report a wrong brightness level and requires human intervention to restore the desired brightness.
I have fixed aforementioned problems with this patch I am submitting.
This patch (composed of two distinct patches) compiles without warnings on both gcc and clang and also improves a function signature and constant-correctness of the kernel driver.
Denis Benato (2):
hid-asus: add const to read-only outgoing usb buffer
hid-asus: reset the backlight brightness level on resume
drivers/hid/hid-asus.c | 27 +++++++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)
--
2.42.1
next reply other threads:[~2023-11-17 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 1:15 Luke D. Jones [this message]
2023-11-17 1:15 ` [PATCH 1/2] hid-asus: add const to read-only outgoing usb buffer Luke D. Jones
2023-11-17 1:15 ` [PATCH 2/2] hid-asus: reset the backlight brightness level on resume Luke D. Jones
2023-11-17 19:51 ` [PATCH 0/2] " Denis Benato
2023-11-21 8:52 ` Jiri Kosina
2023-11-21 19:35 ` Luke Jones
2023-11-22 10:25 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117011556.13067-1-luke@ljones.dev \
--to=luke@ljones.dev \
--cc=benato.denis96@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).