From: Conor Dooley <conor@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Support Opensource <support.opensource@diasemi.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 03/11] dt-bindings: input: Convert da906{1,2,3} onkey to json-schema
Date: Sun, 3 Dec 2023 11:36:00 +0000 [thread overview]
Message-ID: <20231203-protozoan-degrease-432575e9dc1d@spud> (raw)
In-Reply-To: <20231202192536.266885-4-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 2268 bytes --]
On Sat, Dec 02, 2023 at 07:25:27PM +0000, Biju Das wrote:
> diff --git a/Documentation/devicetree/bindings/input/dlg,da9062-onkey.yaml b/Documentation/devicetree/bindings/input/dlg,da9062-onkey.yaml
> new file mode 100644
> index 000000000000..34f2e00cf045
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/dlg,da9062-onkey.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/dlg,da9062-onkey.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog DA9061/62/63 OnKey Module
> +
> +maintainers:
> + - Biju Das <biju.das.jz@bp.renesas.com>
> +
> +description: |
> + This module is part of the DA9061/DA9062/DA9063. For more details about entire
> + DA9062 and DA9061 chips see Documentation/devicetree/bindings/mfd/da9062.txt
> + For DA906{1,2,3} see Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> +
> + This module provides the KEY_POWER event.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - dlg,da9062-onkey
> + - dlg,da9063-onkey
> + - items:
> + - enum:
> + - dlg,da9061-onkey
> + - const: dlg,da9062-onkey # da9062-onkey fallback
Same comments here.
Cheers,
Conor.
> + dlg,disable-key-power:
> + type: boolean
> + description:
> + Disable power-down using a long key-press. If this entry exists
> + the OnKey driver will remove support for the KEY_POWER key press
> + when triggered using a long press of the OnKey.
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pmic@58 {
> + compatible = "dlg,da9063";
> + reg = <0x58>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> +
> + onkey {
> + compatible = "dlg,da9063-onkey";
> + dlg,disable-key-power;
> + };
> + };
> + };
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-03 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 19:25 [PATCH v2 00/11] Convert DA906{1,2} bindings to json-schema Biju Das
2023-12-02 19:25 ` [PATCH v2 03/11] dt-bindings: input: Convert da906{1,2,3} onkey " Biju Das
2023-12-03 11:36 ` Conor Dooley [this message]
2023-12-04 10:58 ` Biju Das
2023-12-05 20:19 ` kernel test robot
2023-12-06 9:39 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231203-protozoan-degrease-432575e9dc1d@spud \
--to=conor@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox