Linux Input/HID development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 0/2] Fixes for spurious wakeups on some Lenovo laptops
Date: Sat, 2 Dec 2023 21:24:29 -0600	[thread overview]
Message-ID: <20231203032431.30277-1-mario.limonciello@amd.com> (raw)

Users have reported the inability to properly suspend on
Lenovo Yoga Slim 7 Gen 8 14APU8 and Lenovo YogaAir 14s APU8

Analyzing the problem there are two issues where HID devices connected
over I2C cause spurious wakeup events or high power consumption.

One of the HID devices isn't configured as a wakeup source so the APU
if the interrupt fires over suspend it will wake the APU from a hardware
sleep state but will not return control to the OS.

The second HID device is configured as a wakeup source and continually
fires both at runtime and suspend.

This series mitigates the impact from both of these devices.

Mario Limonciello (2):
  HID: i2c-hid: Add IDEA5002 to i2c_hid_acpi_blacklist[]
  pinctrl: amd: Mask non-wake source pins with interrupt enabled at
    suspend

 drivers/hid/i2c-hid/i2c-hid-acpi.c | 5 +++++
 drivers/pinctrl/pinctrl-amd.c      | 9 +++++++++
 drivers/pinctrl/pinctrl-amd.h      | 5 +++++
 3 files changed, 19 insertions(+)

-- 
2.34.1


             reply	other threads:[~2023-12-03  3:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03  3:24 Mario Limonciello [this message]
2023-12-03  3:24 ` [PATCH 1/2] HID: i2c-hid: Add IDEA5002 to i2c_hid_acpi_blacklist[] Mario Limonciello
2023-12-04 15:18   ` Jiri Kosina
2023-12-03  3:24 ` [PATCH 2/2] pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend Mario Limonciello
2023-12-04 14:46   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231203032431.30277-1-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox