From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A22E336AEA; Mon, 18 Dec 2023 16:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Sv4pT6VLwz6K5yX; Tue, 19 Dec 2023 00:21:53 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id A7F3D140A77; Tue, 19 Dec 2023 00:22:29 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 18 Dec 2023 16:22:29 +0000 Date: Mon, 18 Dec 2023 16:22:27 +0000 From: Jonathan Cameron To: Srinivas Pandruvada CC: , , , , , , , Subject: Re: [PATCH 0/2] Fix regression in ALS Message-ID: <20231218162227.00002197@Huawei.com> In-Reply-To: <20231217200703.719876-1-srinivas.pandruvada@linux.intel.com> References: <20231217200703.719876-1-srinivas.pandruvada@linux.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) On Sun, 17 Dec 2023 12:07:01 -0800 Srinivas Pandruvada wrote: > Addition of color temperature and chromaticity support breaks ALS sensor > on several platforms. Till we have a good solution, revert these commits > for 6.7 cycle. > > Srinivas Pandruvada (2): > Revert "iio: hid-sensor-als: Add light chromaticity support" > Revert "iio: hid-sensor-als: Add light color temperature support" > > drivers/iio/light/hid-sensor-als.c | 100 +---------------------------- > include/linux/hid-sensor-ids.h | 4 -- > 2 files changed, 2 insertions(+), 102 deletions(-) +CC Greg KH. (resent as I messed up Greg's address first time around) Hi Greg, This is a regression fix that I'd like to get in asap. Currently light sensors on a wide range of laptops are broken. I was hoping we'd fix the the problem rather than need to revert, but time is running out so revert it is. I don't have anything else that needs to be rushed in before the merge cycle, so if you are happy to pick these two reverts directly that would be great. Message ID of the cover letter is 20231217200703.719876-1-srinivas.pandruvada@linux.intel.com Acked-by: Jonathan Cameron If not I should be able to do a pull request in next couple of days with these in. Thanks, Jonathan >