From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F6EF5EE88; Tue, 26 Dec 2023 00:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fcMd1KMP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 476ACC433C7; Tue, 26 Dec 2023 00:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703550424; bh=oa+jeY8QggxWots0Rz6Rd64iuGZY8wj+tpbT3/d4Fxs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fcMd1KMPrBl6d6sz1665KnCggTeYSeREQ0gwFjUK8yMV0BOZZFc++Ea45yLVObHQJ j37jMxQHMp3mCvqtRm+bMmcHqjdtMynZChBneQbr1rZhDkfsnPTWSkiSqky8D+RV7j lJxKqUXtrF5ldKCabKsXqOopNh2wkiZFGh24b71aAlXsGmbBEukfL4BuIwF98IqLpX LtPn6955ebh3EqMnggYJxBl0tM455bbXmTLoXVdsQCUK/mCCxKCm9GxTv2SuZsUXvy rvxQgpX155gt4ZiAzWsQMVwS48us7FXd50yBiq8CR23vDhV/uxc6MKl40OcTCOKBA7 uexu1I75DLgXA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Dmitry Torokhov , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 4/7] Input: amimouse - convert to platform remove callback returning void Date: Mon, 25 Dec 2023 19:26:28 -0500 Message-ID: <20231226002649.7290-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231226002649.7290-1-sashal@kernel.org> References: <20231226002649.7290-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.303 Content-Transfer-Encoding: 8bit From: Uwe Kleine-König [ Upstream commit 42b8ff47720258d1f6a4412e780a480c139773a0 ] The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231201133747.1099286-2-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/mouse/amimouse.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/input/mouse/amimouse.c b/drivers/input/mouse/amimouse.c index a33437c480e36..c93f9c03f7d73 100644 --- a/drivers/input/mouse/amimouse.c +++ b/drivers/input/mouse/amimouse.c @@ -129,16 +129,15 @@ static int __init amimouse_probe(struct platform_device *pdev) return 0; } -static int __exit amimouse_remove(struct platform_device *pdev) +static void __exit amimouse_remove(struct platform_device *pdev) { struct input_dev *dev = platform_get_drvdata(pdev); input_unregister_device(dev); - return 0; } static struct platform_driver amimouse_driver = { - .remove = __exit_p(amimouse_remove), + .remove_new = __exit_p(amimouse_remove), .driver = { .name = "amiga-mouse", }, -- 2.43.0