From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8DD8156984 for ; Mon, 29 Jan 2024 16:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706547452; cv=none; b=o1fNe9TmLMbE7DHOsnD/2CJT4ZT2d3UjumrolDLLhj8AcUfPBObrgcI82zO2i0U2ocUen8K0OqkT+TwLdn+U4AcyH4FuLsnPTCRP1lgiFE9WLLGYjQbJZMPwHDbdcm2qteoX3sdGgkSuOraLiZTuc1nptormV1Qy5UAkMLA9Usw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706547452; c=relaxed/simple; bh=PYJV/zCof9bA47ax26MefA3jG31IKhzbByzoCNvZ2I8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ja/B6cKNBIhWmzhpiMhMWZR03Vi/qQDZ1HPR9zVJ09osw10E31ZFAKurBjinmv2nC5SNrdVVrFrlO9ub4q93jHEBhI+9/hue6g3eT0Ui+qN2iH7OgKFIvwax7Py755tFnhBfjAaEKrWI+pSSXXvJlJfu4OxNUVPV6RYbrF9evr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Vi8Y6JME; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vi8Y6JME" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40e8fec0968so38654475e9.1 for ; Mon, 29 Jan 2024 08:57:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706547449; x=1707152249; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=P9wTVsDZPi9luD11blK9ZetydoMmmMOCQpHaskiEUG8=; b=Vi8Y6JME6K13PIHEYFpkm+UvY+QIqD97ax+RkQiaDwFIzCt4Di/UGvrvzCU6BnqMtW 91E7x4GPkp71SF6gIPiRmVQ3f+w0BgSAzMKnS8WqgSddsPXZn3y4BydHD8jIO3JPeefa h/1/4c/Pnseso6K34zWzAhjR2WPCULdHQbZzVH8L6IHoHQU3BMaqTRvf0+GhuPp4EQxr 4YgZLIyPXbAX2DMz8p1Jpy+/iHIo3ccV3VBg/pJH4XRkiC90C44XEkk6QjgOgTBUQDvE vmn+5GIgihywv/InYnCho+V1XnNhHplWqDtzYphi93bHNkvzrQZk+iDaBqiTV5nchBRm Mxlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706547449; x=1707152249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P9wTVsDZPi9luD11blK9ZetydoMmmMOCQpHaskiEUG8=; b=XHcJI2QZ8XXJl4x70jRBxz2NRhRyk5k7/a/KeIAX2depkEsMGWKVVO81cFjQVYPJhH N0LRQYH1JlXNLn4QgyBPIlRcQNe4y+MudXrQ9z3fGFzUCItq83tPlNx5PsnJ/6P617TJ HsBLEjobbYVVCG1dyY3tQgkHmaXJf0hORCopHX2N66iYTb/9gz8g+TbygtKg/4iIf7kI v5WEZkQ7SLBee+MqrvSMmxXoSHnPcsVW2lB5ABOVYygZAEwVKawVHYRmh5wYad1GuXrR wLjtjOtBlnsAGUvb7Kz+6K982jMmHXH1G9AaimWpy+sFdTefe9ykyzADU6Pva1W+92jI XR6Q== X-Gm-Message-State: AOJu0Yyj60PCy8XTrZMWsGwBWrbSvlvtgibD0AY59ghodrFYDzrwgNkp WQV6B5LJYQFxin5H++dU6Fb3hRmELZ8I8EjfyhkouTIFuNNsvK7DjJswB4PgOUE= X-Google-Smtp-Source: AGHT+IF0FIjSQ29fIM0nPO06gQYurBpkH6rYrh1FycF+QEIuZSgXDS1CLBlZ2OOp2thB6a/dIkH+8g== X-Received: by 2002:a05:600c:3b82:b0:40e:5332:4062 with SMTP id n2-20020a05600c3b8200b0040e53324062mr5626780wms.33.1706547448841; Mon, 29 Jan 2024 08:57:28 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id k26-20020a05600c1c9a00b0040ef79b2fa6sm3008972wms.33.2024.01.29.08.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 08:57:28 -0800 (PST) Date: Mon, 29 Jan 2024 16:57:26 +0000 From: Daniel Thompson To: Bjorn Andersson Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Tissoires , Jiri Kosina , Bjorn Andersson , Konrad Dybcio , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sc8280xp-x13s: Fix/enable touchscreen Message-ID: <20240129165726.GA4700@aspen.lan> References: <20240129-x13s-touchscreen-v3-0-c4a933034145@quicinc.com> <20240129-x13s-touchscreen-v3-2-c4a933034145@quicinc.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129-x13s-touchscreen-v3-2-c4a933034145@quicinc.com> On Mon, Jan 29, 2024 at 08:47:48AM -0800, Bjorn Andersson wrote: > The touchscreen present on some SKUs of Lenovo Thinkpad X13s is never > detected by Linux. Power is applied and the device is brought out of > reset using the pinconfig in DeviceTree, but the read-test in > __i2c_hid_core_probe() fails to access the device, which result in probe > being aborted. > > Some users have reported success after rebinding the device. > > Looking to the ACPI tables, there's a 5ms after-power and a 200ms > after-reset delay. The power-supply is shared with other components, so > this is active all the way through boot. The reset GPIO, on the other > hand, is low (reset asserted) at boot, so this is first deasserted by > the implicit application of the pinconf state. > > This means the time between reset deassert and __i2c_hid_core_probe() is > significantly below the value documented in the ACPI tables. > > As the I2C HID binding and driver support specifying a reset gpio, > replace the pinconf-based scheme to pull the device out of reset. Then > specify the after-reset time. > > The shared power rail is currently always on, but in case this ever > change, the after-power delay is added as well, to not violate the > power-on to reset-deassert timing requirement. > > Fixes: 32c231385ed4 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree") > Tested-by: Daniel Thompson For the sake of completeness (and to make sure I don't forget if anyone asks me in the future) I also (successfully) tested with the output high removed from the touchscreen pinctrl. Daniel. PS Strictly speaking I tested v2 and am replying to v3... but the DT should be the same for both versions ;-).